From: Jan Kiszka <jan.kiszka@web.de>
To: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
Cc: Thierry Bultel <thierry.bultel@wanadoo.fr>, xenomai@xenomai.org
Subject: Re: [Xenomai] Target frozen with rtcan_virt
Date: Wed, 10 Oct 2012 09:56:50 +0200 [thread overview]
Message-ID: <50752A42.9080303@web.de> (raw)
In-Reply-To: <507528E4.4050809@xenomai.org>
On 2012-10-10 09:51, Gilles Chanteperdrix wrote:
> On 10/10/2012 09:38 AM, Thierry Bultel wrote:
>> Hi Gilles,
>>
>> Many thanks,
>> The first patch does not work, the second does.
>> I think the reason for 1st patch why is that in rtcan_virt, we have
>>
>> rtdm_lock_get_irqsave(&rtcan_recv_list_lock, lock_ctx);
>> rtdm_lock_get(&rtcan_socket_lock);
>>
>> ...
>> ---> rtcan_rcv(rx_dev, &skb);
>> ....
>>
>> rtdm_lock_put(&rtcan_socket_lock);
>> rtdm_lock_put_irqrestore(&rtcan_recv_list_lock, lock_ctx);
>>
>> and rtcan_rcv->rtcan_rcv_deliver->rtdm_sem_up(&sock->recv_sem);
>>
>> thus the same re-scheduling stuff with interrupts locked.
>>
>> Are you not not afraid of side effects with the second patch,
>> since you change the overall behaviour ?
>> Won't you prefer a only locally modified rtcan_virt ?
>
> We should ask Jan's opinion. In any case, if we adopt the second patch,
> we might want to try and reduce the overhead of xnpod_unlock_sched.
>
We were signaling the semaphore while holding a spin lock? That's a
clear bug. Your patch is aligning rtcan to the pattern we are also using
in RTnet. We just need to make sure (haven't looked at the full context
yet) that sock remains valid even after dropping the lock(s).
Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
URL: <http://www.xenomai.org/pipermail/xenomai/attachments/20121010/72167921/attachment.pgp>
next prev parent reply other threads:[~2012-10-10 7:56 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <505EB99F.7050705@wanadoo.fr>
2012-09-23 7:42 ` [Xenomai] Target frozen with rtcan_virt Thierry Bultel
2012-09-23 13:23 ` Gilles Chanteperdrix
2012-09-23 14:57 ` Thierry Bultel
2012-09-23 14:59 ` Gilles Chanteperdrix
2012-10-09 12:45 ` Thierry Bultel
2012-10-09 21:34 ` Gilles Chanteperdrix
2012-10-09 21:41 ` Gilles Chanteperdrix
2012-10-09 21:51 ` Gilles Chanteperdrix
2012-10-10 7:38 ` Thierry Bultel
2012-10-10 7:51 ` Gilles Chanteperdrix
2012-10-10 7:56 ` Jan Kiszka [this message]
2012-10-10 8:04 ` Gilles Chanteperdrix
2012-10-10 8:10 ` Jan Kiszka
2012-10-10 8:58 ` Gilles Chanteperdrix
2012-10-10 9:01 ` Jan Kiszka
2012-10-10 9:23 ` Gilles Chanteperdrix
2012-10-10 10:04 ` Jan Kiszka
2012-10-10 10:07 ` Gilles Chanteperdrix
2012-10-10 10:25 ` Jan Kiszka
2012-10-10 10:54 ` Philippe Gerum
2012-10-10 11:30 ` Gilles Chanteperdrix
2012-10-10 12:09 ` Philippe Gerum
2012-10-10 12:33 ` Gilles Chanteperdrix
2012-10-10 12:41 ` Philippe Gerum
2012-10-10 12:43 ` Philippe Gerum
2012-10-10 12:45 ` Philippe Gerum
2012-10-10 12:55 ` Gilles Chanteperdrix
2012-10-10 12:57 ` Philippe Gerum
2012-10-10 13:01 ` Gilles Chanteperdrix
2012-10-10 13:09 ` Philippe Gerum
2012-10-10 13:16 ` Gilles Chanteperdrix
2012-10-10 13:18 ` Philippe Gerum
2012-10-10 13:19 ` Gilles Chanteperdrix
2012-10-10 13:57 ` Philippe Gerum
2012-10-10 14:52 ` Gilles Chanteperdrix
2012-10-11 8:05 ` Gilles Chanteperdrix
2012-11-05 13:33 ` Thierry Bultel
2012-11-05 18:46 ` Gilles Chanteperdrix
2012-11-06 7:22 ` Thierry Bultel
2012-11-06 11:59 ` Philippe Gerum
2012-11-06 14:49 ` Gilles Chanteperdrix
2012-10-10 13:17 ` Philippe Gerum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50752A42.9080303@web.de \
--to=jan.kiszka@web.de \
--cc=gilles.chanteperdrix@xenomai.org \
--cc=thierry.bultel@wanadoo.fr \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.