From: Paolo Bonzini <pbonzini@redhat.com>
To: jcody@redhat.com
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] block: make bdrv_find_backing_image compare canonical filenames
Date: Wed, 10 Oct 2012 10:07:05 +0200 [thread overview]
Message-ID: <50752CA9.8010802@redhat.com> (raw)
In-Reply-To: <50752AD6.4040604@redhat.com>
Il 10/10/2012 09:59, Jeff Cody ha scritto:
>> Unfortunately realpath does not exist on Win32. But
>> http://lists.gnu.org/archive/html/grub-devel/2011-09/msg00034.html
>> suggests that there is a _fullpath and in fact already has all you need
>> to write a qemu_realpath function.
>
> Doesn't block.c already rely on realpath(), in bdrv_open()? Why would
> this be any different using it here?
Uh, indeed there's already a _fullpath wrapper in qemu-common.h. My
bad, I only grepped os*.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
next prev parent reply other threads:[~2012-10-10 8:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 5:56 [Qemu-devel] [PATCH 0/2] block-commit fixes Jeff Cody
2012-10-10 5:56 ` [Qemu-devel] [PATCH 1/2] block: make bdrv_find_backing_image compare canonical filenames Jeff Cody
2012-10-10 7:34 ` Paolo Bonzini
2012-10-10 7:59 ` Jeff Cody
2012-10-10 8:07 ` Paolo Bonzini [this message]
2012-10-10 18:13 ` Eric Blake
2012-10-10 18:29 ` Jeff Cody
2012-10-10 18:34 ` Eric Blake
2012-10-10 18:57 ` Jeff Cody
2012-10-10 19:15 ` Eric Blake
2012-10-12 21:52 ` Eric Blake
2012-10-13 15:25 ` Jeff Cody
2012-10-16 11:40 ` Kevin Wolf
2012-10-10 5:56 ` [Qemu-devel] [PATCH 2/2] block: in commit, determine base image from the top image Jeff Cody
2012-10-10 7:35 ` Paolo Bonzini
2012-10-10 18:18 ` Eric Blake
2012-10-11 15:36 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50752CA9.8010802@redhat.com \
--to=pbonzini@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.