From: Hannes Reinecke <hare@suse.de>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-scsi@vger.kernel.org, "Joel D. Diaz" <joeldiaz@us.ibm.com>
Subject: Re: [PATCH] sd: Reshuffle init_sd to avoid crash
Date: Wed, 10 Oct 2012 12:01:09 +0200 [thread overview]
Message-ID: <50754765.8040304@suse.de> (raw)
In-Reply-To: <1349862941.2452.11.camel@dabdike.int.hansenpartnership.com>
On 10/10/2012 11:55 AM, James Bottomley wrote:
> On Wed, 2012-10-10 at 10:36 +0200, Hannes Reinecke wrote:
>> scsi_register_driver will register a prep_fn() function, which
>> in turn migh need to use the sd_cdp_pool for DIF.
>> Which hasn't been initialised at this point, leading to
>> a crash. So reshuffle the init_sd() and exit_sd() paths
>> to have the driver registered last.
>>
>> Signed-off-by: Joel D. Diaz <joeldiaz@us.ibm.com>
>> Signed-off-by: Hannes Reinecke <hare@suse.de>
>
> Explain what these signoffs mean, since the patch is sent with you as
> the author.
>
Ah. Sorry.
Joel Diaz send the patch relative to SLES11 SP2, and I ported / send
it to mainline.
So yeah, Joel is actually the author.
Should I send an updated patch?
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-10-10 10:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 8:36 [PATCH] sd: Reshuffle init_sd to avoid crash Hannes Reinecke
2012-10-10 9:55 ` James Bottomley
2012-10-10 10:01 ` Hannes Reinecke [this message]
2012-10-10 11:49 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50754765.8040304@suse.de \
--to=hare@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=joeldiaz@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.