Re: [PATCH] qv4l2: avoid empty titles for the video control tabs

["Frank Schäfer" <fschaefer.oss@googlemail.com>]

Am 09.10.2012 17:24, schrieb Hans Verkuil:
> On Tue October 9 2012 16:46:04 Frank Schäfer wrote:
>> The video control class names are used as titles for the GUI-tabs.
>> The current code relies on the driver enumerating the control classes
>> properly when using V4L2_CTRL_FLAG_NEXT_CTRL.
>> But the UVC-driver (and likely others, too) don't do that, so we can end
>> up with an empty class name string.
>>
>> Make sure we always have a control class title:
>> If the driver didn't enumrate a class along with the controls, call
>> VIDIOC_QUERYCTRL for the class explicitly.
>> If that fails, fall back to an internal string list.
> NACK.
>
> qv4l2 is for testing drivers, so I *want* to see if a driver doesn't provide
> the control class name. They really should provide it, and it is not something
> that should be papered over.

Hehe, ok.
Then you might want to remove all the "papering-over" code a few lines
above, too ? ;)

Regards,
Frank

> Regards,
>
> 	Hans