All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiangfu Liu <xiangfu@openmobilefree.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] add nand spl boot for qi_lb60 board
Date: Thu, 11 Oct 2012 11:19:45 +0800	[thread overview]
Message-ID: <50763AD1.8080903@openmobilefree.net> (raw)
In-Reply-To: <CACUy__WYybkqrGiXv7Y1z0ReAubUzRhd0PJm9ZT+GboU438CZQ@mail.gmail.com>

Hi Tom Rini

I cannot easy find a way to use 'puts' instead 'serial_puts' in my code.
any advise will be great. 

Thanks
Xiangfu

On 10/10/2012 05:27 AM, Daniel Schwierzeck wrote:
>> I'm happy you've moved to the new SPL infrastructure.  A few comments:
>>
>> In general, please check for checkpatch.pl issues, I spotted a few.
>> Also, don't use // comments in asm, everything else in MIPS uses '#' or
>> '/* ... */'.  Please use 'puts' rather than 'serial_puts' directly.
>>

  parent reply	other threads:[~2012-10-11  3:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-09  8:28 [U-Boot] [PATCH v3] add nand spl boot for qi_lb60 board xiangfu at openmobilefree.net
2012-10-09 16:37 ` Tom Rini
2012-10-09 21:27   ` Daniel Schwierzeck
2012-10-11  2:14     ` Xiangfu Liu
2012-10-11  3:19     ` Xiangfu Liu [this message]
2012-10-11 22:23       ` Tom Rini
  -- strict thread matches above, loose matches on Subject: below --
2012-01-06 10:17 [U-Boot] [PATCH v2] " Xiangfu Liu
2012-01-10 15:06 ` [U-Boot] [PATCH v3] " Xiangfu Liu
2012-03-06 21:04   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50763AD1.8080903@openmobilefree.net \
    --to=xiangfu@openmobilefree.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.