* [PATCH 3.6.0- 3/6] ARM/pxa: use module_platform_driver macro
@ 2012-10-10 18:30 ` Srinivas KANDAGATLA
0 siblings, 0 replies; 3+ messages in thread
From: Srinivas KANDAGATLA @ 2012-10-10 18:30 UTC (permalink / raw)
To: paul, rnayak
Cc: srinivas.kandagatla, Hiroshi.DOYU, tony, linux-omap, tarun.kanti,
thara, grinberg, eric.y.miao, linux-arm-kernel, juha.yrjola
From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
This patch removes some code duplication by using
module_platform_driver.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
---
arch/arm/mach-pxa/pxa3xx-ulpi.c | 13 +------------
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/arch/arm/mach-pxa/pxa3xx-ulpi.c b/arch/arm/mach-pxa/pxa3xx-ulpi.c
index 7dbe3cc..e329cce 100644
--- a/arch/arm/mach-pxa/pxa3xx-ulpi.c
+++ b/arch/arm/mach-pxa/pxa3xx-ulpi.c
@@ -384,18 +384,7 @@ static struct platform_driver pxa3xx_u2d_ulpi_driver = {
.probe = pxa3xx_u2d_probe,
.remove = pxa3xx_u2d_remove,
};
-
-static int pxa3xx_u2d_ulpi_init(void)
-{
- return platform_driver_register(&pxa3xx_u2d_ulpi_driver);
-}
-module_init(pxa3xx_u2d_ulpi_init);
-
-static void __exit pxa3xx_u2d_ulpi_exit(void)
-{
- platform_driver_unregister(&pxa3xx_u2d_ulpi_driver);
-}
-module_exit(pxa3xx_u2d_ulpi_exit);
+module_platform_driver(pxa3xx_u2d_ulpi_driver);
MODULE_DESCRIPTION("PXA3xx U2D ULPI driver");
MODULE_AUTHOR("Igor Grinberg");
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 3.6.0- 3/6] ARM/pxa: use module_platform_driver macro
@ 2012-10-10 18:30 ` Srinivas KANDAGATLA
0 siblings, 0 replies; 3+ messages in thread
From: Srinivas KANDAGATLA @ 2012-10-10 18:30 UTC (permalink / raw)
To: linux-arm-kernel
From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
This patch removes some code duplication by using
module_platform_driver.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
---
arch/arm/mach-pxa/pxa3xx-ulpi.c | 13 +------------
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/arch/arm/mach-pxa/pxa3xx-ulpi.c b/arch/arm/mach-pxa/pxa3xx-ulpi.c
index 7dbe3cc..e329cce 100644
--- a/arch/arm/mach-pxa/pxa3xx-ulpi.c
+++ b/arch/arm/mach-pxa/pxa3xx-ulpi.c
@@ -384,18 +384,7 @@ static struct platform_driver pxa3xx_u2d_ulpi_driver = {
.probe = pxa3xx_u2d_probe,
.remove = pxa3xx_u2d_remove,
};
-
-static int pxa3xx_u2d_ulpi_init(void)
-{
- return platform_driver_register(&pxa3xx_u2d_ulpi_driver);
-}
-module_init(pxa3xx_u2d_ulpi_init);
-
-static void __exit pxa3xx_u2d_ulpi_exit(void)
-{
- platform_driver_unregister(&pxa3xx_u2d_ulpi_driver);
-}
-module_exit(pxa3xx_u2d_ulpi_exit);
+module_platform_driver(pxa3xx_u2d_ulpi_driver);
MODULE_DESCRIPTION("PXA3xx U2D ULPI driver");
MODULE_AUTHOR("Igor Grinberg");
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 3.6.0- 3/6] ARM/pxa: use module_platform_driver macro
2012-10-10 18:30 ` Srinivas KANDAGATLA
(?)
@ 2012-10-11 6:36 ` Igor Grinberg
-1 siblings, 0 replies; 3+ messages in thread
From: Igor Grinberg @ 2012-10-11 6:36 UTC (permalink / raw)
To: linux-arm-kernel
On 10/10/12 20:30, Srinivas KANDAGATLA wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>
> This patch removes some code duplication by using
> module_platform_driver.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
Cc'ed Haojian,
I agree on Paul's comment about the description.
Otherwise looks fine to me:
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
> arch/arm/mach-pxa/pxa3xx-ulpi.c | 13 +------------
> 1 files changed, 1 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/pxa3xx-ulpi.c b/arch/arm/mach-pxa/pxa3xx-ulpi.c
> index 7dbe3cc..e329cce 100644
> --- a/arch/arm/mach-pxa/pxa3xx-ulpi.c
> +++ b/arch/arm/mach-pxa/pxa3xx-ulpi.c
> @@ -384,18 +384,7 @@ static struct platform_driver pxa3xx_u2d_ulpi_driver = {
> .probe = pxa3xx_u2d_probe,
> .remove = pxa3xx_u2d_remove,
> };
> -
> -static int pxa3xx_u2d_ulpi_init(void)
> -{
> - return platform_driver_register(&pxa3xx_u2d_ulpi_driver);
> -}
> -module_init(pxa3xx_u2d_ulpi_init);
> -
> -static void __exit pxa3xx_u2d_ulpi_exit(void)
> -{
> - platform_driver_unregister(&pxa3xx_u2d_ulpi_driver);
> -}
> -module_exit(pxa3xx_u2d_ulpi_exit);
> +module_platform_driver(pxa3xx_u2d_ulpi_driver);
>
> MODULE_DESCRIPTION("PXA3xx U2D ULPI driver");
> MODULE_AUTHOR("Igor Grinberg");
--
Regards,
Igor.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-11 6:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-10 18:30 [PATCH 3.6.0- 3/6] ARM/pxa: use module_platform_driver macro Srinivas KANDAGATLA
2012-10-10 18:30 ` Srinivas KANDAGATLA
2012-10-11 6:36 ` Igor Grinberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.