Re: p2p question

["Arend van Spriel" <arend@broadcom.com>]

On 10/10/2012 11:31 PM, Johannes Berg wrote:
> On Wed, 2012-10-10 at 23:24 +0200, Arend van Spriel wrote:
>> Hi Johannes,
>>
>> Reading the comment on .add_virtual_intf() callback I am a bit confused.
>>
>> =====
>>    * @add_virtual_intf: create a new virtual interface with the given name,
>>    *	must set the struct wireless_dev's iftype. Beware: You must create
>>    *	the new netdev in the wiphy's network namespace! Returns the struct
>>    *	wireless_dev, or an ERR_PTR. For P2P device wdevs, the driver must
>>    *	also set the address member in the wdev.
>> =====
>>
>> The last sentence refers to the "address member in wdev", but at least
>> in my tree struct wireless_dev does not have an address member. Missing
>> something here?
>
> It does in my tree?
>
> struct wireless_dev {
> ...
>          u8 address[ETH_ALEN] __aligned(sizeof(u16));
>
> maybe you missed it?

Likely. Still working on 3.6-rc5 so missing "cfg80211: add P2P Device 
abstraction". It is probably time to merge, which I was avoiding until 
3.7-rc1 was available. Sorry for the noise.

Gr. AvS