From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMKh8-0002vi-Ig for qemu-devel@nongnu.org; Thu, 11 Oct 2012 11:29:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TMKh2-0002FJ-RQ for qemu-devel@nongnu.org; Thu, 11 Oct 2012 11:29:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TMKh2-0002F3-J7 for qemu-devel@nongnu.org; Thu, 11 Oct 2012 11:29:00 -0400 Message-ID: <5076DDBD.50903@redhat.com> Date: Thu, 11 Oct 2012 16:54:53 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20121011105705.GE5552@redhat.com> <20121011142122.GH3592@redhat.com> <20121011144656.GF8983@redhat.com> In-Reply-To: <20121011144656.GF8983@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 21/21] q35: add acpi-based pci hotplug. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: aliguori@us.ibm.com, juzhang@redhat.com, jan.kiszka@siemens.com, Jason Baron , qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, armbru@redhat.com, kraxel@redhat.com Il 11/10/2012 16:46, Michael S. Tsirkin ha scritto: > Yes. Reason I ask is because q35 is adding bridges by default now. > Would it be possible to only add them if requested on command line by user > instead? Can you just use shpc or pcie hotplug on those bridges? > I realize some guests expect devices at specific slots > but this does not apply to bridges I think? > > It would also be nice to add comments explaining why > specific slots were selected e.g. /* BSD XYZ fails to boot unless ahci is at alow 2 */ > etc. > > Also - will adding this code now mean that when adding bridges > we'll need to add compatibility code in bios/qemu in the future? It will need SSDT changes. One ugliness of Jason's patch was that it introduced a massive chain of 32*32 Ifs in the SSDT. Changing it to use LoadTable shouldn't be hard. Then you can patch out the LoadTable (e.g. _INI -> INI_) based on what QEMU tells you is a bridge or not. Paolo