Re: [PATCH v3] can: flexcan: disable bus error interrupts for the i.MX6q

[Wolfgang Grandegger <wg@grandegger.com>]

Hi Marc,

On 10/11/2012 03:39 PM, Marc Kleine-Budde wrote:
> From: Wolfgang Grandegger <wg@grandegger.com>
> 
> Due to a bug in most Flexcan cores, the bus error interrupt needs
> to be enabled. Otherwise we don't get any error warning or passive
> interrupts. This is _not_ necessary for the i.MX6q and this patch
> disables bus error interrupts if "berr-reporting" is not requested.
> This avoids bus error flooding, which might harm, especially on
> low-end systems.

Should be something like:

This patch adds some Flexcan version info and removes the feature flag
FLEXCAN_HAS_BROKEN_ERR_STATE for the i.MX6Q. It also has the line
[TR]WRN_INT properly connected.

> Cc: Hui Wang <jason77.wang@gmail.com>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
> [mkl: convert to incremental patch]
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> Changes since v3:
> - convert to incremental patch
> - update mx6 glitch filter information
> ---
> Hello Wolfgang,
> 
> I've converted your patch so that it can be applied to current net, where David
> already accepted your v1 version of the patch.

Thanks, I will not have time before this evening. Looks good, apart from
the commit message. Feel free to go ahead.

Thanks,

Wolfgang.