From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 2/2] fs: add partition switch libary, implement ls and fsload commands
Date: Thu, 11 Oct 2012 09:47:09 -0700 [thread overview]
Message-ID: <5076F80D.1030304@ti.com> (raw)
In-Reply-To: <1349913907-25845-2-git-send-email-swarren@wwwdotorg.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/10/12 17:05, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Implement "ls" and "fsload" commands that act like
> {fat,ext2}{ls,load}, and transparently handle either file-system.
> This scheme could easily be extended to other filesystem types; I
> only didn't do it for zfs because I don't have any filesystems of
> that type.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com> --- There are a
> couple FIXMEs in here:
>
> 1) In fs/fs.c, code is ifdef on CONFIG_CMD_FAT or CONFIG_CMD_EXT2.
> This means that the new commands and code can only be enabled if
> the "legacy" {fat,ext2}{ls,load} are enabled. What we really want
> is CONFIG_FS_FAT and CONFIG_FS_EXT2 to enable the filesystem code,
> and then CONFIG_CMD_FAT, CONFIG_CMD_EXT2, CONFIG_CMD_FS to only
> affect the command implementations. However, that would require
> making every include/config/*.h that sets the current defines also
> set more. I suppose that's a fairly mechanical change though, so
> easy enough to implement. Does that seem like a reasonable approach
> to people?
How about a new CONFIG_CMD_GENERIC_FS for the new ls/fsload (and any
later commands like write that get added) and once most filesystems
are converted we can think about a transition plan?
> 2) In common/Makefile, I need to make this conditional upon
> CONFIG_CMD_FS or similar.
>
> Also, I wonder if the fs/* and common/* should be two separate
> patches or not?
One is fine.
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
iQIcBAEBAgAGBQJQdvgNAAoJENk4IS6UOR1Wx3gP/iRvYq0khe6ZPRbUcPyTg0r8
tkNJGfglXba52GHjU6URwSrPbN9qOHzh6fD0x26jOdj1vWlMv6nvwmyo3ttvyRLe
4VF7tvTRp3Zv461vGwm8XwAXlDXVrnsWeC4veWxo+/ptFaq2FTWYTVNo2MsqHSIN
VNnxMdgtqUIU2kgx0uJst1Fl3olDaRlQmyf88SiRE2et21FQytk/LxAc50zmNr5J
UWgVgzoUP+RnZwnZK2CWL9cAuGbEyLjQvoKK8V72dMvKzZgMFpyMEdk0+onKFYe1
Byai7INodWIhWrtQj4nGC/1WQC+kCteMvF3OTjuGY/bfDPqLYx3071kocrgYWSW4
URvvdv6hn1l+evN5BQ1erwAekwfgrfcKkavJwmuVES3ZESrEyComqWEjajqeTe/6
uIpZo58oFGojJZK1HcDmaVFyj7nxAzXloupmHiKq+xfXHbv60ZUZO6InEos/ZCjZ
bpT92wyyqTeiD70glLvLRyStKzZidqeoVTkbGM0XUCA3d3RvxXdB4zfgIqDlhhCT
EfhxKVkAZAzjsEn+U1/y5RWEEdD+Zaqi2xKwA+Ken9TJ4LFsjcOiQDPVZYklD7qu
Xmte9GdxL4tSipu0hWxrkRjO7ap09wUoEk1d0jNSrwNbJALnUUkT4qfpYXcMaAhe
okjWSANQaBZxbM0ziEoT
=AnRj
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-10-11 16:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 0:05 [U-Boot] [RFC PATCH 1/2] fs: delete unused Makefile Stephen Warren
2012-10-11 0:05 ` [U-Boot] [RFC PATCH 2/2] fs: add partition switch libary, implement ls and fsload commands Stephen Warren
2012-10-11 13:33 ` Benoît Thébaudeau
2012-10-11 16:47 ` Tom Rini [this message]
2012-10-11 16:57 ` Stephen Warren
2012-10-11 17:05 ` Tom Rini
2012-10-11 17:45 ` Benoît Thébaudeau
2012-10-13 19:26 ` Pavel Herrmann
2012-10-15 15:43 ` Stephen Warren
2012-10-13 0:31 ` [U-Boot] [RFC PATCH 1/2] fs: delete unused Makefile Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5076F80D.1030304@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.