From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] examples/ip_pipeline: fix freebsd build
	error
Date: Tue, 10 Apr 2018 12:15:08 +0200
Message-ID: <50779258.T1JUn8BQf7@xps>
References: <20180409120632.38567-1-jasvinder.singh@intel.com>
 <20180410095132.130232-1-jasvinder.singh@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, cristian.dumitrescu@intel.com
To: Jasvinder Singh <jasvinder.singh@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 6A8CC1B6A9
 for <dev@dpdk.org>; Tue, 10 Apr 2018 12:15:11 +0200 (CEST)
In-Reply-To: <20180410095132.130232-1-jasvinder.singh@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

10/04/2018 11:51, Jasvinder Singh:
> IP_Pipeline app is not supported in FreeBSD environment. Therefore,
> skip it while building the sample apps on FreeBSD.
[...]
> --- a/examples/ip_pipeline/Makefile
> +++ b/examples/ip_pipeline/Makefile
> @@ -67,6 +67,13 @@ RTE_TARGET ?= x86_64-native-linuxapp-gcc
>  
>  include $(RTE_SDK)/mk/rte.vars.mk
>  
> +ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp")

You can use CONFIG_RTE_EXEC_ENV_LINUXAPP

> +$(info This application can only operate in a linuxapp environment, \
> +please change the definition of the RTE_TARGET environment variable)
> +all:
> +clean:
> +else


Copy of my previous comment:
"
It is not skipping the example, just throwing an error (which is needed).

You should add a test in examples/Makefile to really skip it.
"

In this v2, you replaced the error by an info message.
Error was better in my opinion.