All of lore.kernel.org
 help / color / mirror / Atom feed
From: gshark <gshark.jeong@gmail.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Richard Purdie <rpurdie@rpsys.net>,
	Daniel Jeong <daniel.jeong@ti.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] backlight: lm3639: Return proper error in lm3639_bled_mode_store error paths
Date: Fri, 12 Oct 2012 13:49:03 +0900	[thread overview]
Message-ID: <5077A13F.3090100@gmail.com> (raw)
In-Reply-To: <1349932292.8495.2.camel@phoenix>

2012년 10월 11일 14:11, Axel Lin 쓴 글:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>   drivers/video/backlight/lm3639_bl.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c
> index c6915c6..585949b 100644
> --- a/drivers/video/backlight/lm3639_bl.c
> +++ b/drivers/video/backlight/lm3639_bl.c
> @@ -206,11 +206,11 @@ static ssize_t lm3639_bled_mode_store(struct device *dev,
>   
>   out:
>   	dev_err(pchip->dev, "%s:i2c access fail to register\n", __func__);
> -	return size;
> +	return ret;
>   
>   out_input:
>   	dev_err(pchip->dev, "%s:input conversion fail\n", __func__);
> -	return size;
> +	return ret;
>   
>   }
>   

Thank you Alex for fixing code.
Acked-by: G.Shark Jeong<gshark.jeong@gmail.com>

      reply	other threads:[~2012-10-12  4:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-11  5:11 [PATCH] backlight: lm3639: Return proper error in lm3639_bled_mode_store error paths Axel Lin
2012-10-12  4:49 ` gshark [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5077A13F.3090100@gmail.com \
    --to=gshark.jeong@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=axel.lin@ingics.com \
    --cc=daniel.jeong@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.