From: Teresa Gamez <t.gamez@phytec.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM OMAP: Create device file
Date: Fri, 12 Oct 2012 11:30:40 +0200 [thread overview]
Message-ID: <5077E340.2010205@phytec.de> (raw)
In-Reply-To: <20121012075835.GG27665@pengutronix.de>
Am 12.10.2012 09:58, schrieb Sascha Hauer:
Hello Sascha,
> Nice work. As Jean Christophe already mentioned, it would be nice to
> skip the base address. That would mean to have a omap_add_mmc() function
> like above in an omap generic place and then:
>
> static inline struct device_d omap<x>_add_mmc<y>(void *pdata)
> {
> omap_add_mmc(OMAPx_MMCy_BASE, pdata);
> }
>
> in omap3/4 specific include files.
>
> Let me know if you want to work on this, otherwise I'm also happy to
> apply this one as it's already a step forward.
I will change it as you suggested.
I would base my rework on next so I can apply the changes also on the
archosg9 board.
Teresa
>
> Sascha
>
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2012-10-12 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 7:25 [PATCH 1/2] ARM OMAP: Create device file Teresa Gámez
2012-10-11 7:25 ` [PATCH 2/2] ARM OMAP: Use wrapper in board files Teresa Gámez
2012-10-11 12:44 ` Jean-Christophe PLAGNIOL-VILLARD
2012-10-12 7:58 ` [PATCH 1/2] ARM OMAP: Create device file Sascha Hauer
2012-10-12 9:30 ` Teresa Gamez [this message]
2012-10-13 12:10 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5077E340.2010205@phytec.de \
--to=t.gamez@phytec.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.