From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Arend van Spriel <arend@broadcom.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Linux Wireless List <linux-wireless@vger.kernel.org>,
Jouni Malinen <j@w1.fi>,
Stanislav Yakovlev <stas.yakovlev@gmail.com>,
Dan Williams <dcbw@redhat.com>, Bing Zhao <bzhao@marvell.com>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH 1/3] wireless: drivers: make use of WLAN_EID_VENDOR_SPECIFIC
Date: Fri, 12 Oct 2012 13:46:11 +0300 [thread overview]
Message-ID: <5077F4F3.8030409@qca.qualcomm.com> (raw)
In-Reply-To: <1350037696-23747-2-git-send-email-arend@broadcom.com>
On 10/12/2012 01:28 PM, Arend van Spriel wrote:
> The include file linux/ieee80211.h contains three definitions for
> the same thing in enum ieee80211_eid due to historic changes:
>
> /* Information Element IDs */
> enum ieee80211_eid {
> :
> WLAN_EID_WPA = 221,
> WLAN_EID_GENERIC = 221,
> WLAN_EID_VENDOR_SPECIFIC = 221,
> :
> };
>
> The standard refers to this as "vendor specific" element so the
> other two definitions are better not used. This patch changes the
> wireless drivers to use one definition, ie. WLAN_EID_VENDOR_SPECIFIC.
Why not remove _WPA and _GENERIC from ieee80211.h at the same time so
that nobody else won't use them in the future?
> Cc: Kalle Valo <kvalo@qca.qualcomm.com>
> Cc: Jouni Malinen <j@w1.fi>
> Cc: Stanislav Yakovlev <stas.yakovlev@gmail.com>
> Cc: Dan Williams <dcbw@redhat.com>
> Cc: Bing Zhao <bzhao@marvell.com>
> Cc: Larry Finger <Larry.Finger@lwfinger.net>
> Signed-off-by: Arend van Spriel <arend@broadcom.com>
For the ath6kl part:
Acked-by: Kalle Valo <kvalo@qca.qualcomm.com>
Kalle
next prev parent reply other threads:[~2012-10-12 11:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 10:28 [PATCH 0/3] wireless: only use WLAN_EID_VENDOR_SPECIFIC Arend van Spriel
2012-10-12 10:28 ` [PATCH 1/3] wireless: drivers: make use of WLAN_EID_VENDOR_SPECIFIC Arend van Spriel
2012-10-12 10:46 ` Kalle Valo [this message]
2012-10-12 11:19 ` Kalle Valo
2012-10-12 13:06 ` Arend van Spriel
2012-10-13 1:55 ` Bing Zhao
2012-10-13 2:48 ` Larry Finger
2012-10-13 11:50 ` Stanislav Yakovlev
2012-10-12 10:28 ` [PATCH 2/3] wireless: gelic: " Arend van Spriel
2012-10-12 10:28 ` [PATCH 3/3] wireless: remove duplicate enum ieee80211_eid definitions Arend van Spriel
2012-10-15 10:55 ` [PATCH 0/3] wireless: only use WLAN_EID_VENDOR_SPECIFIC Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5077F4F3.8030409@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=Larry.Finger@lwfinger.net \
--cc=arend@broadcom.com \
--cc=bzhao@marvell.com \
--cc=dcbw@redhat.com \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stas.yakovlev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.