From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andy Gross <andy.gross@ti.com>
Subject: Re: [PATCH] drm/omap: Fix release of refill engine
Date: Fri, 12 Oct 2012 09:44:50 -0500
Message-ID: <50782CE2.3090603@ti.com>
References: <1350014892-5069-1-git-send-email-andy.gross@ti.com>
	<CAF6AEGt8MYqHN5qEDTiSTpH9Lat0HXJHP_ZmaUUhVxNfAb=yZA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from arroyo.ext.ti.com (arroyo.ext.ti.com [192.94.94.40])
	by gabe.freedesktop.org (Postfix) with ESMTP id E05509E9D6
	for <dri-devel@lists.freedesktop.org>;
	Fri, 12 Oct 2012 07:44:52 -0700 (PDT)
In-Reply-To: <CAF6AEGt8MYqHN5qEDTiSTpH9Lat0HXJHP_ZmaUUhVxNfAb=yZA@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Rob Clark <rob@ti.com>
Cc: Greg Kroah-Hartman <greg@kroah.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On 10/12/2012 08:44 AM, Rob Clark wrote:
>
> US);
>
>          for (i = 0; i < dmm->num_engines; i++) {
> -               if (status & DMM_IRQSTAT_LST)
> +               if (status & DMM_IRQSTAT_LST) {
>                          wake_up_interruptible(&dmm->engines[i].wait_for_refill);
>
> +                       if (&dmm->engines[i].async)
> Are you sure about that & ?  That looks like a typo, rather than what you want..

Good catch.  I'll fix that, retest, and resubmit.