From: Rob Herring <robherring2@gmail.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
jonathan@jonmasters.org, eric.dumazet@gmail.com,
Mark Langsdorf <mark.langsdorf@calxeda.com>
Subject: Re: [PATCH 5/6] net: calxedaxgmac: rework transmit ring handling
Date: Fri, 12 Oct 2012 12:01:00 -0500 [thread overview]
Message-ID: <50784CCC.3050300@gmail.com> (raw)
In-Reply-To: <1350059332.2819.18.camel@bwh-desktop.uk.solarflarecom.com>
On 10/12/2012 11:28 AM, Ben Hutchings wrote:
> On Fri, 2012-10-12 at 10:15 -0500, Rob Herring wrote:
>> From: Rob Herring <rob.herring@calxeda.com>
>>
>> Only generate tx interrupts on every ring size / 4 descriptors. Move the
>> netif_stop_queue call to the end of the xmit function rather than
>> checking at the beginning.
> [...]
>
> The hardware should also interrupt if the TX ring becomes empty; does it
> do that?
Yes, with the "tx buffer unavailable" bit DMA_INTR_ENA_TUE. It is not a
per descriptor interrupt.
However, I just noticed I missed part of this patch to actually enable
tx descriptor interrupt. New version coming.
Rob
next prev parent reply other threads:[~2012-10-12 17:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 15:15 [PATCH 0/6] Calxeda xgmac performance fixes Rob Herring
2012-10-12 15:15 ` [PATCH 1/6] net: calxedaxgmac: enable operate on 2nd frame mode Rob Herring
2012-10-12 15:15 ` [PATCH 2/6] net: calxedaxgmac: remove explicit rx dma buffer polling Rob Herring
2012-10-12 15:15 ` [PATCH 3/6] net: calxedaxgmac: use relaxed i/o accessors in rx and tx paths Rob Herring
2012-10-12 15:15 ` [PATCH 4/6] net: calxedaxgmac: drop some unnecessary register writes Rob Herring
2012-10-12 15:15 ` [PATCH 5/6] net: calxedaxgmac: rework transmit ring handling Rob Herring
2012-10-12 16:28 ` Ben Hutchings
2012-10-12 17:01 ` Rob Herring [this message]
2012-10-12 18:04 ` [PATCH v2] " Rob Herring
2012-10-12 18:30 ` Eric Dumazet
2012-10-12 20:21 ` Rob Herring
2012-10-12 15:15 ` [PATCH 6/6] net: calxedaxgmac: ip align receive buffers Rob Herring
2012-10-29 17:52 ` [PATCH 0/6] Calxeda xgmac performance fixes Rob Herring
2012-10-29 18:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50784CCC.3050300@gmail.com \
--to=robherring2@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=jonathan@jonmasters.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.langsdorf@calxeda.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.