From: Eric Blake <eblake@redhat.com>
To: Kashyap Chamarthy <kashyap.cv@gmail.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Benoît Canet" <benoit@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command
Date: Fri, 12 Oct 2012 14:31:50 -0600 [thread overview]
Message-ID: <50787E36.2090308@redhat.com> (raw)
In-Reply-To: <CAOaxAcbDNmO2265LNvmCur0DPOEu29SEWOG66jTB5owNs1jxOA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]
On 10/12/2012 02:19 PM, Kashyap Chamarthy wrote:
>
> From eb4c4bc92c035c42c23c30c5e7ee73b54f9cf3a8 Mon Sep 17 00:00:00 2001
> From: Kashyap Chamarthy <kashyap.cv@gmail.com>
> Date: Sat, 13 Oct 2012 01:30:37 +0530
> Subject: [PATCH] Add documentation for 'qemu-img info --backing-chain'
>
> Signed-off-by: Kashyap Chamarthy <kashyap.cv@gmail.com>
> ---
> qemu-img.texi | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
We also need a patch to qemu-img-cmds.hx.
> @@ -129,7 +133,7 @@ created as a copy on write image of the specified base image; the
> @var{backing_file} should have the same content as the input's base image,
> however the path, image format, etc may differ.
>
> -@item info [-f @var{fmt}] [--output=@var{ofmt}] @var{filename}
> +@item info [-f @var{fmt}] [--output=@var{ofamt}] [--backing-chain] @var{filename}
Introduced a spurious typo:
s/ofamt/ofmt/
>
> Give information about the disk image @var{filename}. Use it in
> particular to know the size reserved on disk which can be different
> @@ -137,6 +141,19 @@ from the displayed size. If VM snapshots are stored in the disk image,
> they are displayed too. The command can output in the format @var{ofmt}
> which is either @code{human} or @code{json}.
>
> +If a disk image has a backing file chain, information about each disk image in
> +the chain can be recursively enumerated by using the option @code{--backing-chain}
Trailing whitespace. Needs a '.' to end the sentence.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]
next prev parent reply other threads:[~2012-10-12 20:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 14:09 [Qemu-devel] [PATCH] qemu-img: Add --backing-chain option to info command Stefan Hajnoczi
2012-10-12 14:18 ` Eric Blake
2012-10-12 14:24 ` Eric Blake
2012-10-12 14:27 ` Kevin Wolf
2012-10-12 14:32 ` Eric Blake
2012-10-12 14:38 ` Kevin Wolf
2012-10-12 14:50 ` Eric Blake
2012-10-12 19:16 ` Kashyap Chamarthy
2012-10-12 20:19 ` Kashyap Chamarthy
2012-10-12 20:31 ` Eric Blake [this message]
2012-10-13 15:50 ` Kashyap Chamarthy
2012-10-13 21:36 ` Eric Blake
2012-10-14 6:10 ` Kashyap Chamarthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50787E36.2090308@redhat.com \
--to=eblake@redhat.com \
--cc=benoit@irqsave.net \
--cc=kashyap.cv@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.