All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, Antoine Reversat <a.reversat@gmail.com>
Subject: Re: [PATCH v3] omap3isp: Use monotonic timestamps for statistics buffers
Date: Sat, 13 Oct 2012 13:25:17 +0300	[thread overview]
Message-ID: <5079418D.5000903@iki.fi> (raw)
In-Reply-To: <1350065617-17136-1-git-send-email-laurent.pinchart@ideasonboard.com>

Hi Laurent,

Thanks for the update!

Laurent Pinchart wrote:
> V4L2 buffers use the monotonic clock, while statistics buffers use wall
> time. This makes it difficult to correlate video frames and statistics.
>
> Switch statistics buffers to the monotonic clock to fix this.
>
> Reported-by: Antoine Reversat <a.reversat@gmail.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>   drivers/media/platform/omap3isp/ispstat.c |    5 +++--
>   drivers/media/platform/omap3isp/ispstat.h |    2 +-
>   2 files changed, 4 insertions(+), 3 deletions(-)
>
> Given the hard NACK on the switch to timespec for the public API in v2, v3 goes
> back to the same approach as v1.

Acked-by: Sakari Ailus <sakari.ailus@iki.fi>

-- 
Sakari Ailus
sakari.ailus@iki.fi

      reply	other threads:[~2012-10-13 10:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-12 18:13 [PATCH v3] omap3isp: Use monotonic timestamps for statistics buffers Laurent Pinchart
2012-10-13 10:25 ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5079418D.5000903@iki.fi \
    --to=sakari.ailus@iki.fi \
    --cc=a.reversat@gmail.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.