From: kishon <kishon@ti.com>
To: Vivek Gautam <gautam.vivek@samsung.com>
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org, gregkh@linuxfoundation.org,
balbi@ti.com, rob.herring@calxeda.com, thomas.abraham@linaro.org,
av.tikhomirov@samsung.com
Subject: Re: [PATCH 1/2] USB: dwc3-exynos: Add support for device tree
Date: Sat, 13 Oct 2012 19:24:31 +0530 [thread overview]
Message-ID: <50797297.7070102@ti.com> (raw)
In-Reply-To: <1350136052-25583-2-git-send-email-gautam.vivek@samsung.com>
Hi,
On Saturday 13 October 2012 07:17 PM, Vivek Gautam wrote:
> This patch adds support to parse probe data for
> dwc3 driver for exynos using device tree
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> ---
> drivers/usb/dwc3/dwc3-exynos.c | 22 ++++++++++++++++++++++
> 1 files changed, 22 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
> index ca65978..78e6219 100644
> --- a/drivers/usb/dwc3/dwc3-exynos.c
> +++ b/drivers/usb/dwc3/dwc3-exynos.c
> @@ -21,6 +21,7 @@
> #include <linux/clk.h>
> #include <linux/usb/otg.h>
> #include <linux/usb/nop-usb-xceiv.h>
> +#include <linux/of.h>
>
> #include "core.h"
>
> @@ -87,6 +88,8 @@ err1:
> return ret;
> }
>
> +static u64 dwc3_exynos_dma_mask = DMA_BIT_MASK(32);
> +
> static int __devinit dwc3_exynos_probe(struct platform_device *pdev)
> {
> struct dwc3_exynos_data *pdata = pdev->dev.platform_data;
> @@ -103,6 +106,16 @@ static int __devinit dwc3_exynos_probe(struct platform_device *pdev)
> goto err0;
> }
>
> + /*
> + * Right now device-tree probed devices don't get dma_mask set.
> + * Since shared usb code relies on it, set it here for now.
> + * Once we move to full device tree support this will vanish off.
> + */
> + if (!pdev->dev.dma_mask)
> + pdev->dev.dma_mask = &dwc3_exynos_dma_mask;
> + if (!pdev->dev.coherent_dma_mask)
> + pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
of/platform.c shows coherent_dma_mask is set for dt.
Thanks
Kishon
next prev parent reply other threads:[~2012-10-13 13:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-13 13:47 [PATCH 0/2] USB: dwc3-exynos: Adding device tree support Vivek Gautam
2012-10-13 13:47 ` [PATCH 1/2] USB: dwc3-exynos: Add support for device tree Vivek Gautam
2012-10-13 13:54 ` kishon [this message]
2012-10-13 13:47 ` [PATCH 2/2] USB: DWC3: EXYNOS: Remove platform data for dwc3-exynos Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50797297.7070102@ti.com \
--to=kishon@ti.com \
--cc=av.tikhomirov@samsung.com \
--cc=balbi@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gautam.vivek@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.