Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add wrapper to look up neighbor and send skb

[Marek Lindner <lindner_marek@yahoo.de>]

On 10/14/2012 01:30 AM, Martin Hundebøll wrote:
> +bool batadv_send_skb_to_orig(struct sk_buff *skb,
> +			     struct batadv_orig_node *orig_node,
> +			     struct batadv_hard_iface *recv_if)
> +{
> +	struct batadv_priv *bat_priv = orig_node->bat_priv;
> +	struct batadv_neigh_node *neigh_node;
> +
> +	/* batadv_find_router() increases neigh_nodes refcount if found. */
> +	neigh_node = batadv_find_router(bat_priv, orig_node, recv_if);
> +	if (!neigh_node)
> +		return false;
> +
> +	/* route it */
> +	batadv_send_skb_packet(skb, neigh_node->if_incoming, neigh_node->addr);
> +
> +	batadv_neigh_node_free_ref(neigh_node);
> +
> +	return true;
> +}

Our new quality standards demand proper kernel documentation for each 
new function / struct / define added to the code.
Only 3 months ago this code would have been acceptable.  ;-)

Cheers,
Marek

PS: The version information is missing in the subject of this mail. 
Please help your maintainer from hell to save some time ...  :)