From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNFWl-0000M7-2G for qemu-devel@nongnu.org; Sun, 14 Oct 2012 00:10:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TNFWk-00051o-30 for qemu-devel@nongnu.org; Sun, 14 Oct 2012 00:10:11 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44579 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNFWj-0004kg-Kb for qemu-devel@nongnu.org; Sun, 14 Oct 2012 00:10:09 -0400 Message-ID: <507A3B14.3050502@suse.de> Date: Sun, 14 Oct 2012 06:09:56 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1350160539-22293-1-git-send-email-imammedo@redhat.com> In-Reply-To: <1350160539-22293-1-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5] target-i386: initialize APIC at CPU level List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: jan.kiszka@siemens.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, ehabkost@redhat.com Am 13.10.2012 22:35, schrieb Igor Mammedov: > (L)APIC is a part of cpu [1] so move APIC initialization inside of > x86_cpu object. Since cpu_model and override flags currently specify > whether APIC should be created or not, APIC creation&initialization is > moved into x86_cpu_apic_init() which is called from x86_cpu_realize(). >=20 > [1] - all x86 cpus have integrated APIC if we overlook existence of i48= 6, > and it's more convenient to model after majority of them. >=20 > Signed-off-by: Igor Mammedov > --- > v5: fix *-user target build, smp_cpus is defined for softmmu only I do not run into any build issue with v4. Is it a runtime issue? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg