From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chegu Vinod Subject: Re: [PATCH] KVM: apic: fix LDR calculation in x2apic mode Date: Sun, 14 Oct 2012 06:41:52 -0700 Message-ID: <507AC120.4010308@hp.com> References: <20121014110858.GN16648@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, avi@redhat.com, mtosatti@redhat.com To: Gleb Natapov Return-path: Received: from g4t0014.houston.hp.com ([15.201.24.17]:38298 "EHLO g4t0014.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751070Ab2JNNly (ORCPT ); Sun, 14 Oct 2012 09:41:54 -0400 In-Reply-To: <20121014110858.GN16648@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/14/2012 4:08 AM, Gleb Natapov wrote: > Signed-off-by: Gleb Natapov > diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c > index c6e6b72..43e9fad 100644 > --- a/arch/x86/kvm/lapic.c > +++ b/arch/x86/kvm/lapic.c > @@ -1311,7 +1311,7 @@ void kvm_lapic_set_base(struct kvm_vcpu *vcpu, u64 value) > vcpu->arch.apic_base = value; > if (apic_x2apic_mode(apic)) { > u32 id = kvm_apic_id(apic); > - u32 ldr = ((id & ~0xf) << 16) | (1 << (id & 0xf)); > + u32 ldr = ((id >> 4) << 16) | (1 << (id & 0xf)); > kvm_apic_set_ldr(apic, ldr); > } > apic->base_address = apic->vcpu->arch.apic_base & > -- > Gleb. > . > Reviewed-by: Chegu Vinod Tested-by: Chegu Vinod