From: "Andreas Färber" <afaerber@suse.de>
To: Lei Li <lilei@linux.vnet.ibm.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support.
Date: Mon, 15 Oct 2012 13:09:55 +0200 [thread overview]
Message-ID: <507BEF03.5050208@suse.de> (raw)
In-Reply-To: <507BB25E.2030401@linux.vnet.ibm.com>
Am 15.10.2012 08:51, schrieb Lei Li:
> On 10/12/2012 08:39 PM, Gerd Hoffmann wrote:
>> +void qmp_chardev_del(const char *id, Error **errp)
>> +{
>> + CharDriverState *chr;
>> +
>> + chr = qemu_chr_find(id);
>> + if (NULL == chr) {
>> + error_setg(errp, "Chardev '%s' not found\n", id);
>
> Maybe this should be replaced by QERR_ macros to keep
> compatibility since this one is listed in ErrorClass
> in the schema, like:
>
> error_set(errp, QERR_DEVICE_NOT_FOUND, id);
No, error_setg() is the new replacement, QERR_* is deprecated.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-10-15 11:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 9:25 [Qemu-devel] [PULL 0/7] serial device hotplug patch series Gerd Hoffmann
2012-10-12 9:25 ` [Qemu-devel] [PATCH 1/7] serial: split serial.c Gerd Hoffmann
2012-10-12 9:25 ` [Qemu-devel] [PATCH 2/7] serial: add pci variant Gerd Hoffmann
2012-10-12 9:25 ` [Qemu-devel] [PATCH 3/7] serial: add windows inf file for the pci card to docs Gerd Hoffmann
2012-10-12 9:25 ` [Qemu-devel] [PATCH 4/7] serial: add 2x + 4x pci variant Gerd Hoffmann
2012-10-12 9:26 ` [Qemu-devel] [PATCH 5/7] usb-serial: don't magically zap chardev on umplug Gerd Hoffmann
2012-10-12 9:26 ` [Qemu-devel] [PATCH 6/7] usb-serial: only expose device in guest when the chardev is open Gerd Hoffmann
2012-10-12 9:26 ` [Qemu-devel] [PATCH 7/7] chardev: add hotplug support Gerd Hoffmann
2012-10-12 9:40 ` Paolo Bonzini
2012-10-12 10:23 ` Gerd Hoffmann
2012-10-12 10:50 ` Paolo Bonzini
2012-10-12 11:15 ` Gerd Hoffmann
2012-10-12 11:17 ` Paolo Bonzini
2012-10-12 12:37 ` Gerd Hoffmann
2012-10-12 12:39 ` [Qemu-devel] [PATCH v2] " Gerd Hoffmann
2012-10-12 13:12 ` Gerd Hoffmann
2012-10-12 16:54 ` Paolo Bonzini
2012-10-12 17:08 ` Paolo Bonzini
2012-10-15 6:51 ` Lei Li
2012-10-15 11:09 ` Andreas Färber [this message]
2012-10-16 13:23 ` Luiz Capitulino
2012-10-15 17:36 ` Eric Blake
2012-10-16 14:02 ` Paolo Bonzini
2012-10-12 9:42 ` [Qemu-devel] [PULL 0/7] serial device hotplug patch series Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507BEF03.5050208@suse.de \
--to=afaerber@suse.de \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lilei@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.