[Powertop] [PATCH] fix typo and correct coding styles in report_formatter

[Powertop] [PATCH] fix typo and correct coding styles in report_formatter

[Sergey Senozhatsky]

[-- Attachment #1: Type: text/plain, Size: 2318 bytes --]

[PATCH] fix typo and correct coding styles in report_formatter

Igor noted a typo and coding styles errors in previous patch, correct them.

Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>

---

 src/report/report-formatter.h | 36 ++++++++++++++++++------------------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/src/report/report-formatter.h b/src/report/report-formatter.h
index 7f9f544..d532f30 100644
--- a/src/report/report-formatter.h
+++ b/src/report/report-formatter.h
@@ -33,33 +33,33 @@ class report_formatter
 public:
 	virtual ~report_formatter() {}
 
-	virtual void finish_report() {};
-	virtual const char *get_result() {return "Basic report_formatter::get_resul call\n";};
-	virtual void clear_result() {};
+	virtual void finish_report() {}
+	virtual const char *get_result() {return "Basic report_formatter::get_result() call\n";}
+	virtual void clear_result() {}
 
-	virtual void add(const char *str) {};
-	virtual void addv(const char *fmt, va_list ap) {};
+	virtual void add(const char *str) {}
+	virtual void addv(const char *fmt, va_list ap) {}
 
-	virtual void add_header(const char *header, int level) {};
+	virtual void add_header(const char *header, int level) {}
 
-	virtual void begin_section(section_type stype) {};
-	virtual void end_section() {};
+	virtual void begin_section(section_type stype) {}
+	virtual void end_section() {}
 
-	virtual void begin_table(table_type ttype) {};
-	virtual void end_table() {};
+	virtual void begin_table(table_type ttype) {}
+	virtual void end_table() {}
 
-	virtual void begin_row(row_type rtype) {};
-	virtual void end_row() {};
+	virtual void begin_row(row_type rtype) {}
+	virtual void end_row() {}
 
-	virtual void begin_cell(cell_type ctype) {};
-	virtual void end_cell() {};
-	virtual void add_empty_cell() {};
+	virtual void begin_cell(cell_type ctype) {}
+	virtual void end_cell() {}
+	virtual void add_empty_cell() {}
 
-	virtual void begin_paragraph() {};
-	virtual void end_paragraph() {};
+	virtual void begin_paragraph() {}
+	virtual void end_paragraph() {}
 
 	/* For quad-colouring CPU tables in HTML */
-	virtual void set_cpu_number(int nr) {};
+	virtual void set_cpu_number(int nr) {}
 };
 
 #endif /* _REPORT_FORMATTER_H_ */

Re: [Powertop] [PATCH] fix typo and correct coding styles in report_formatter

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

Dear Sergey,


thank you for your patch.

Am Montag, den 15.10.2012, 02:25 -0700 schrieb Sergey Senozhatsky:
> [PATCH] fix typo and correct coding styles in report_formatter

Please do not repeat the summary in the commit message body.

> Igor noted a typo and coding styles errors in previous patch, correct them.

Two patches are better. If not only that you can make the commit summary
smaller. ;-)

report-formatter.h: Fix typo iget_resul → get_result()
report-formatter.h: Remove ; to adhere to coding style

> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>

[…]


It would be great if you could resend.


Thanks,

Paul

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [Powertop] [PATCH] fix typo and correct coding styles in report_formatter

[Arjan van de Ven]

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

On 10/15/2012 7:02 AM, Paul Menzel wrote:
> Dear Sergey,
> 
> 
> thank you for your patch.
> 
> Am Montag, den 15.10.2012, 02:25 -0700 schrieb Sergey Senozhatsky:
>> [PATCH] fix typo and correct coding styles in report_formatter
> 
> Please do not repeat the summary in the commit message body.

there's nothing wrong with that though.

I rather have one sentence too much, than a too short commit message.

Re: [Powertop] [PATCH] fix typo and correct coding styles in report_formatter

[Sergey Senozhatsky]

[-- Attachment #1: Type: text/plain, Size: 996 bytes --]

On (10/15/12 16:02), Paul Menzel wrote:
> thank you for your patch.
> 
> Am Montag, den 15.10.2012, 02:25 -0700 schrieb Sergey Senozhatsky:
> > [PATCH] fix typo and correct coding styles in report_formatter
> 
> Please do not repeat the summary in the commit message body.
>

I do like this line in git shortlog, the only thing with that line
is that *probably* [PATCH] should not be there, but I can't see any
problems with it anyway.


> > Igor noted a typo and coding styles errors in previous patch, correct them.
> 
> Two patches are better. If not only that you can make the commit summary
> smaller. ;-)
>

why? two patches are good for bisecting, no one ever will bisect those
2 small changes.

	-ss
 
> report-formatter.h: Fix typo iget_resul → get_result()
> report-formatter.h: Remove ; to adhere to coding style
> 
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>
> 
> […]
> 
> 
> It would be great if you could resend.
> 

Re: [Powertop] [PATCH] fix typo and correct coding styles in report_formatter

[Chris Ferron]

[-- Attachment #1: Type: text/plain, Size: 2785 bytes --]

On 10/15/2012 02:25 AM, Sergey Senozhatsky wrote:
> [PATCH] fix typo and correct coding styles in report_formatter
>
> Igor noted a typo and coding styles errors in previous patch, correct them.
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky(a)gmail.com>
>
> ---
>
>   src/report/report-formatter.h | 36 ++++++++++++++++++------------------
>   1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/src/report/report-formatter.h b/src/report/report-formatter.h
> index 7f9f544..d532f30 100644
> --- a/src/report/report-formatter.h
> +++ b/src/report/report-formatter.h
> @@ -33,33 +33,33 @@ class report_formatter
>   public:
>   	virtual ~report_formatter() {}
>   
> -	virtual void finish_report() {};
> -	virtual const char *get_result() {return "Basic report_formatter::get_resul call\n";};
> -	virtual void clear_result() {};
> +	virtual void finish_report() {}
> +	virtual const char *get_result() {return "Basic report_formatter::get_result() call\n";}
> +	virtual void clear_result() {}
>   
> -	virtual void add(const char *str) {};
> -	virtual void addv(const char *fmt, va_list ap) {};
> +	virtual void add(const char *str) {}
> +	virtual void addv(const char *fmt, va_list ap) {}
>   
> -	virtual void add_header(const char *header, int level) {};
> +	virtual void add_header(const char *header, int level) {}
>   
> -	virtual void begin_section(section_type stype) {};
> -	virtual void end_section() {};
> +	virtual void begin_section(section_type stype) {}
> +	virtual void end_section() {}
>   
> -	virtual void begin_table(table_type ttype) {};
> -	virtual void end_table() {};
> +	virtual void begin_table(table_type ttype) {}
> +	virtual void end_table() {}
>   
> -	virtual void begin_row(row_type rtype) {};
> -	virtual void end_row() {};
> +	virtual void begin_row(row_type rtype) {}
> +	virtual void end_row() {}
>   
> -	virtual void begin_cell(cell_type ctype) {};
> -	virtual void end_cell() {};
> -	virtual void add_empty_cell() {};
> +	virtual void begin_cell(cell_type ctype) {}
> +	virtual void end_cell() {}
> +	virtual void add_empty_cell() {}
>   
> -	virtual void begin_paragraph() {};
> -	virtual void end_paragraph() {};
> +	virtual void begin_paragraph() {}
> +	virtual void end_paragraph() {}
>   
>   	/* For quad-colouring CPU tables in HTML */
> -	virtual void set_cpu_number(int nr) {};
> +	virtual void set_cpu_number(int nr) {}
>   };
>   
>   #endif /* _REPORT_FORMATTER_H_ */
>
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>
>
Your patch has been merged.
Sorry for merging early and missing types, but thank you for the quick fix.
-C