From: Roland Stigge <stigge@antcom.de>
To: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
Cc: Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Srinivas Bakki <srinivas.bakki@nxp.com>,
Kevin Wells <kevin.wells@nxp.com>
Subject: Re: [PATCH RESEND] usb: gadget: lpc32xx_udc: Disable setup request error
Date: Mon, 15 Oct 2012 16:27:03 +0200 [thread overview]
Message-ID: <507C1D37.7060006@antcom.de> (raw)
In-Reply-To: <1350305256-27295-2-git-send-email-aletes.xgr@gmail.com>
On 10/15/2012 02:47 PM, Alexandre Pereira da Silva wrote:
> This message is an debugging message. It's useful for finding protocol
> details but it's not necessarily an error.
>
> Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
Acked-by: Roland Stigge <stigge@antcom.de>
Was also confirmed by the NXP developers a while ago, I think.
> ---
> ---
> drivers/usb/gadget/lpc32xx_udc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/lpc32xx_udc.c b/drivers/usb/gadget/lpc32xx_udc.c
> index 21a9861..d1cf1f4 100644
> --- a/drivers/usb/gadget/lpc32xx_udc.c
> +++ b/drivers/usb/gadget/lpc32xx_udc.c
> @@ -2399,7 +2399,7 @@ static void udc_handle_ep0_setup(struct lpc32xx_udc *udc)
>
> if (i < 0) {
> /* setup processing failed, force stall */
> - dev_err(udc->dev,
> + dev_dbg(udc->dev,
> "req %02x.%02x protocol STALL; stat %d\n",
> reqtype, req, i);
> udc->ep0state = WAIT_FOR_SETUP;
next prev parent reply other threads:[~2012-10-15 14:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 12:47 [PATCH RESEND] usb: gadget: lpc32xx_udc: Fix compatibility with STOTG04 Alexandre Pereira da Silva
2012-10-15 12:47 ` [PATCH RESEND] usb: gadget: lpc32xx_udc: Disable setup request error Alexandre Pereira da Silva
2012-10-15 14:27 ` Roland Stigge [this message]
2012-10-15 13:01 ` [PATCH RESEND] usb: gadget: lpc32xx_udc: Fix compatibility with STOTG04 Felipe Balbi
2012-10-15 14:27 ` Roland Stigge
2012-10-15 14:24 ` Roland Stigge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507C1D37.7060006@antcom.de \
--to=stigge@antcom.de \
--cc=aletes.xgr@gmail.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=kevin.wells@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=srinivas.bakki@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.