Re: [Qemu-devel] [PATCH v2 0/3] qemu-img: Add --backing-chain option to info command

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1370 bytes --]

On 10/15/2012 06:44 AM, Stefan Hajnoczi wrote:
> This series adds the --backing-chain option for enumerating the backing file
> chain.  Given the topmost image it will print qemu-img info information for
> each image file in the chain.
> 
> Special care needs to be taken when image files form an infinite loop.  This is
> very unusual, most like due to malicious image files.  Nevertheless, qemu-img
> must be robust against invalid inputs so we explicit check for this.
> 
> Stefan Hajnoczi (3):
>   qemu-img: Add --backing-chain option to info command
>   qemu-img: Detect backing file chain infinite loops
>   qemu-iotests: Add 041 backing file chain infinite loop test
> 
>  qemu-img.c                   | 115 ++++++++++++++++++++++++++++++++++---------
>  tests/qemu-iotests/041       |  90 +++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/041.out   |  81 ++++++++++++++++++++++++++++++
>  tests/qemu-iotests/common.rc |   9 ++++
>  tests/qemu-iotests/group     |   1 +
>  5 files changed, 274 insertions(+), 22 deletions(-)
>  create mode 100755 tests/qemu-iotests/041
>  create mode 100644 tests/qemu-iotests/041.out

Series: Reviewed-by: Eric Blake <eblake@redhat.com>
although you may need a file rename in patch 3/3

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]