All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Cody <jcody@redhat.com>
To: qemu-devel@nongnu.org
Cc: lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qmp: fix __accept() in qmp.py
Date: Mon, 15 Oct 2012 16:54:23 -0400	[thread overview]
Message-ID: <507C77FF.6030404@redhat.com> (raw)
In-Reply-To: <1350327468-11657-1-git-send-email-jcody@redhat.com>

On 10/15/2012 02:57 PM, Jeff Cody wrote:
> In QEMUMonitorProtocol, commit e9d17b6 removed the __sockfile creation
> from __negotiate_capabilities(), which breaks _accept().  This causes
> failures in qemu-io python based tests (i.e. tests 030 and 040).
> 
> This patch creates the sockfile in __accept() as well.
> ---
>  QMP/qmp.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/QMP/qmp.py b/QMP/qmp.py
> index 33c7d36..32510a1 100644
> --- a/QMP/qmp.py
> +++ b/QMP/qmp.py
> @@ -96,6 +96,7 @@ class QEMUMonitorProtocol:
>          @raise QMPCapabilitiesError if fails to negotiate capabilities
>          """
>          self.__sock, _ = self.__sock.accept()
> +        self.__sockfile = self.__sock.makefile()
>          return self.__negotiate_capabilities()
>  
>      def cmd_obj(self, qmp_cmd):
> 

Forgot the Signed-off-by: on this one, resending

      reply	other threads:[~2012-10-15 20:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-15 18:57 [Qemu-devel] [PATCH] qmp: fix __accept() in qmp.py Jeff Cody
2012-10-15 20:54 ` Jeff Cody [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507C77FF.6030404@redhat.com \
    --to=jcody@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.