From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNub6-0006Px-MX for qemu-devel@nongnu.org; Mon, 15 Oct 2012 20:01:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TNub5-0001rW-82 for qemu-devel@nongnu.org; Mon, 15 Oct 2012 20:01:24 -0400 Received: from cantor2.suse.de ([195.135.220.15]:32906 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TNub4-0001rQ-Sx for qemu-devel@nongnu.org; Mon, 15 Oct 2012 20:01:23 -0400 Message-ID: <507CA3CB.3050705@suse.de> Date: Tue, 16 Oct 2012 02:01:15 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1349378133-25644-1-git-send-email-ehabkost@redhat.com> <1349378133-25644-3-git-send-email-ehabkost@redhat.com> In-Reply-To: <1349378133-25644-3-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC 02/13] qdev: split up header so it can be used in cpu.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Igor Mammedov , qemu-devel@nongnu.org, Anthony Liguori , Paolo Bonzini Am 04.10.2012 21:15, schrieb Eduardo Habkost: > From: Anthony Liguori >=20 > Header file dependency is a frickin' nightmare right now. cpu.h tends = to get > included in our 'include everything' header files but qdev also needs t= o include > those headers mainly for qdev-properties since it knows about CharDrive= rState > and friends. >=20 > We can solve this for now by splitting out qdev.h along the same lines = that we > previously split the C file. Then cpu.h just needs to include qdev-cor= e.h >=20 > [ehabkost: re-add DEFINE_PROP_PCI_HOST_DEVADDR, that was removed on the > original patch (by mistake, I guess)] > [ehabkost: kill qdev_prop_set_vlan() declaration] >=20 > Signed-off-by: Anthony Liguori > Signed-off-by: Eduardo Habkost Generally I am still in favor of doing such a per-topic file split, in whatever way exactly we proceed with CPU-as-a-device. If this is supposed to go through my CPU queue then I would prefer to move the [ehabkost: ...] lines chronologically between the Sobs fwiw. What I would insist on is mentioning both new file names in the commit message (qdev-core.h and qdev-properties.h iiuc) since the +++ stats are ambiguous. I spotted the following textual discrepancy: > diff --git a/hw/qdev-core.h b/hw/qdev-core.h > new file mode 100644 > index 0000000..ca205fc > --- /dev/null > +++ b/hw/qdev-core.h [...] > +/* > + * This callback is used to create Open Firmware device path in accord= ance with > + * OF spec http://forthworks.com/standards/of1275.pdf. Indicidual bus = bindings > + * can be found here http://playground.sun.com/1275/bindings/. > + */ [...] > diff --git a/hw/qdev.h b/hw/qdev.h > index d699194..365b8d6 100644 > --- a/hw/qdev.h > +++ b/hw/qdev.h [...] > - /* > - * This callback is used to create Open Firmware device path in ac= cordance > - * with OF spec http://forthworks.com/standards/of1275.pdf. Indivi= dual bus > - * bindings can be found at http://playground.sun.com/1275/binding= s/. > - */ [snip] "Individual" became "Indicidual" and the comment seems misplaced, which makes myself ask whether this split was not done safely via copy&paste? Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg