From: Greg Ungerer <gerg@snapgear.com>
To: Stany MARCEL <stany.marcel@novasys-ingenierie.com>
Cc: linux-m68k@vger.kernel.org, gerg@uclinux.org
Subject: Re: [PATCH 1/4 V2] Add linux/io.h to make m54xx_wdt.c compile with MMU enabled.
Date: Tue, 16 Oct 2012 15:04:00 +1000 [thread overview]
Message-ID: <507CEAC0.2010107@snapgear.com> (raw)
In-Reply-To: <1350310101-17784-1-git-send-email-stany.marcel@novasys-ingenierie.com>
Hi Stany,
On 16/10/12 00:08, Stany MARCEL wrote:
> Signed-off-by: Stany MARCEL <stany.marcel@novasys-ingenierie.com>
I am fine with it. Though I think you should also include the
actual compile error you get in the commit message.
Acked-by: Greg Ungerer <gerg@uclinux.org>
Being a watchdog driver fix though it needs to also be sent to
the appropriate list and maintainer. get_mainatiner lists:
Wim Van Sebroeck <wim@iguana.be> (maintainer:WATCHDOG DEVICE D...)
linux-watchdog@vger.kernel.org (open list:WATCHDOG DEVICE D...)
linux-kernel@vger.kernel.org (open list)
Regards
Greg
> ---
>
> Changes:
> - V2: reword commit message.
>
> drivers/watchdog/m54xx_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/m54xx_wdt.c b/drivers/watchdog/m54xx_wdt.c
> index 173494a..7466b4b 100644
> --- a/drivers/watchdog/m54xx_wdt.c
> +++ b/drivers/watchdog/m54xx_wdt.c
> @@ -29,6 +29,7 @@
> #include <linux/bitops.h>
> #include <linux/ioport.h>
> #include <linux/uaccess.h>
> +#include <linux/io.h>
>
> #include <asm/coldfire.h>
> #include <asm/m54xxsim.h>
> --
> 1.7.9.5
>
>
>
>
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2012-10-16 5:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 12:54 [PATCH 1/4] Add linux/io.h to make it compile Stany MARCEL
2012-10-15 12:54 ` [PATCH 2/4] Permit to read/write to shared page Stany MARCEL
2012-10-15 12:54 ` [PATCH 3/4] Add for MCF54xx a virtual non cached zone usable for data exchange with DMA Stany MARCEL
2012-10-15 13:22 ` [PATCH 3/4 V2] " Stany MARCEL
2012-10-16 5:15 ` Greg Ungerer
2012-10-16 10:46 ` Stany MARCEL
2012-10-16 11:23 ` Philippe De Muyter
2012-10-16 12:29 ` Greg Ungerer
2012-10-16 13:57 ` RE : " Stany MARCEL
2012-10-15 12:54 ` [PATCH 4/4] Set ACR1 cache mode depending on kernel configuration Stany MARCEL
2012-10-15 13:22 ` [PATCH 4/4 V2] " Stany MARCEL
2012-10-16 5:27 ` Greg Ungerer
2012-10-16 8:12 ` Philippe De Muyter
2012-10-16 12:06 ` Greg Ungerer
2012-10-15 13:58 ` [PATCH 1/4] Add linux/io.h to make it compile Philippe De Muyter
2012-10-15 14:06 ` Stany MARCEL
2012-10-15 14:39 ` Philippe De Muyter
2012-10-16 4:58 ` Greg Ungerer
2012-10-15 14:08 ` [PATCH 1/4 V2] Add linux/io.h to make m54xx_wdt.c compile with MMU enabled Stany MARCEL
2012-10-16 5:04 ` Greg Ungerer [this message]
2012-10-16 10:47 ` Stany MARCEL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507CEAC0.2010107@snapgear.com \
--to=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
--cc=stany.marcel@novasys-ingenierie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.