From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sha Zhengju Subject: Re: [PATCH] oom, memcg: handle sysctl oom_kill_allocating_task while memcg oom happening Date: Tue, 16 Oct 2012 14:32:05 +0800 Message-ID: <507CFF65.7050109@gmail.com> References: <1350367837-27919-1-git-send-email-handai.szj@taobao.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=hw52iVoFTzP/4A5/xAJOJsE362jEqAbfE7tQ5go+Yo8=; b=C4ZhqSdTS0cUdRjsE4AhY3rKrhYDjMvKJgxhan3njGVLzbP6dEwPAoF0AFJ8PJH2Kw vVDTocsnVL2QxAbL5fPvfCdKqwdF0FONbH6MXDCMaWypqPcfDORHVW1cnD0MbhU8bYc6 Rd9AE7uzlLQnGxugeYcNqSBFQt7IrOaHWeCVJMMNWamFXy5oPY5kjUofsYnIGzgZQqQs ls6VxoN1e8wJzYf3X5hwFDOSQ2oHoblcgreONHM0EZVyE186UJr1NMFZCqxap8YsjGE7 RpWm+yy2fEyxZRa6ctgsifJAN0WhBMVvAf/UHJWrn9JiYjnzxO1nSs4wM9Lyi3MS19VK 13BA== In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: David Rientjes Cc: Sha Zhengju , linux-mm@kvack.org, cgroups@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com, akpm@linux-foundation.org, mhocko@suse.cz, linux-kernel@vger.kernel.org On 10/16/2012 02:12 PM, David Rientjes wrote: > On Tue, 16 Oct 2012, Sha Zhengju wrote: > >> From: Sha Zhengju >> >> Sysctl oom_kill_allocating_task enables or disables killing the OOM-triggering >> task in out-of-memory situations, but it only works on overall system-wide oom. >> But it's also a useful indication in memcg so we take it into consideration >> while oom happening in memcg. Other sysctl such as panic_on_oom has already >> been memcg-ware. >> > You're working on an old kernel, mem_cgroup_out_of_memory() has moved to > mm/memcontrol.c. Please rebase on 3.7-rc1 and send an updated patch, > which otherwise looks good. Thanks for reminding! Yes, I cooked it on memcg-devel git repo but a out-of-date since-3.2 branch... But I notice the latest branch is since-3.5(not seeing 3.6/3.7), does it okay to working on this branch? Thanks, Sha -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754131Ab2JPGcD (ORCPT ); Tue, 16 Oct 2012 02:32:03 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:56165 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753617Ab2JPGcA (ORCPT ); Tue, 16 Oct 2012 02:32:00 -0400 Message-ID: <507CFF65.7050109@gmail.com> Date: Tue, 16 Oct 2012 14:32:05 +0800 From: Sha Zhengju User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Thunderbird/3.1.15 MIME-Version: 1.0 To: David Rientjes CC: Sha Zhengju , linux-mm@kvack.org, cgroups@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com, akpm@linux-foundation.org, mhocko@suse.cz, linux-kernel@vger.kernel.org Subject: Re: [PATCH] oom, memcg: handle sysctl oom_kill_allocating_task while memcg oom happening References: <1350367837-27919-1-git-send-email-handai.szj@taobao.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/16/2012 02:12 PM, David Rientjes wrote: > On Tue, 16 Oct 2012, Sha Zhengju wrote: > >> From: Sha Zhengju >> >> Sysctl oom_kill_allocating_task enables or disables killing the OOM-triggering >> task in out-of-memory situations, but it only works on overall system-wide oom. >> But it's also a useful indication in memcg so we take it into consideration >> while oom happening in memcg. Other sysctl such as panic_on_oom has already >> been memcg-ware. >> > You're working on an old kernel, mem_cgroup_out_of_memory() has moved to > mm/memcontrol.c. Please rebase on 3.7-rc1 and send an updated patch, > which otherwise looks good. Thanks for reminding! Yes, I cooked it on memcg-devel git repo but a out-of-date since-3.2 branch... But I notice the latest branch is since-3.5(not seeing 3.6/3.7), does it okay to working on this branch? Thanks, Sha