From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] net: Add tftp speed indication
Date: Tue, 16 Oct 2012 13:22:14 +0200 [thread overview]
Message-ID: <507D4366.4050203@compulab.co.il> (raw)
In-Reply-To: <1349999856-15821-1-git-send-email-sjg@chromium.org>
On 10/12/12 01:57, Simon Glass wrote:
> This prints a tftp speed indication after the download completes. This
> is the 3.6 MiB/s indicator below.
>
> Tegra2 (SeaBoard) # tftp ...
> Using asx0 device
> TFTP from server 172.22.72.144; our IP address is 172.22.73.81
> Filename '/tftpboot/uImage-user-seaboard-1'.
> Load address: 0x408000
> Loading: #################################################
> 3.6 MiB/s
> done
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
Thanks!
> ---
> Changes in v2:
> - Make this feature unconditional (remove need for CONFIG_TFTP_SPEED)
> - Display speed on the next line instead of same line
>
> net/tftp.c | 8 ++++++++
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/net/tftp.c b/net/tftp.c
> index 59a8ebb..09790eb 100644
> --- a/net/tftp.c
> +++ b/net/tftp.c
> @@ -40,6 +40,7 @@
>
> static ulong TftpTimeoutMSecs = TIMEOUT;
> static int TftpTimeoutCountMax = TIMEOUT_COUNT;
> +static ulong time_start; /* Record time we started tftp */
>
> /*
> * These globals govern the timeout behavior when attempting a connection to a
> @@ -299,6 +300,12 @@ static void tftp_complete(void)
> TftpNumchars++;
> }
> #endif
> + time_start = get_timer(time_start);
> + if (time_start > 0) {
> + puts("\n\t "); /* Line up with "Loading: " */
> + print_size(NetBootFileXferSize /
> + time_start * 1000, "/s");
> + }
> puts("\ndone\n");
> net_set_state(NETLOOP_SUCCESS);
> }
> @@ -775,6 +782,7 @@ void TftpStart(enum proto_t protocol)
> TftpState = STATE_SEND_RRQ;
> }
>
> + time_start = get_timer(0);
> TftpTimeoutCountMax = TftpRRQTimeoutCountMax;
>
> NetSetTimeout(TftpTimeoutMSecs, TftpTimeout);
--
Regards,
Igor.
prev parent reply other threads:[~2012-10-16 11:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 0:03 [U-Boot] [PATCH] net: Add tftp speed indication Simon Glass
2012-10-11 7:29 ` Wolfgang Denk
2012-10-11 11:00 ` Igor Grinberg
2012-10-11 23:57 ` [U-Boot] [PATCH v2] " Simon Glass
2012-10-16 11:22 ` Igor Grinberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507D4366.4050203@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.