From: Greg Ungerer <gerg@snapgear.com>
To: Philippe De Muyter <phdm@macqel.be>
Cc: Stany MARCEL <stany.marcel@novasys-ingenierie.com>,
linux-m68k@vger.kernel.org, gerg@uclinux.org
Subject: Re: [PATCH 4/4 V2] Set ACR1 cache mode depending on kernel configuration.
Date: Tue, 16 Oct 2012 22:06:39 +1000 [thread overview]
Message-ID: <507D4DCF.6050304@snapgear.com> (raw)
In-Reply-To: <20121016081202.GB8427@frolo.macqel>
Hi Philippe,
On 10/16/2012 06:12 PM, Philippe De Muyter wrote:
> Hi Stany and Greg,
>
> On Tue, Oct 16, 2012 at 03:27:26PM +1000, Greg Ungerer wrote:
>> Hi Stany,
>>
>> On 15/10/12 23:22, Stany MARCEL wrote:
>>> For coldfire with MMU enabled, data cache did not follow the configuration
>>> but
>>> was configured in writethrough mode.
>>>
>>> Signed-off-by: Stany MARCEL <stany.marcel@novasys-ingenierie.com>
>>
>> Looks good, thanks. Applied without the white space changes.
>
> Wouldn't it be better to move the test on CONFIG_CACHE_COPYBACK outside
> of the test on CONFIG_MMU instead of duplicating it ?
Sure that would be cleaner. If someone updates it and send me a
new patch I will apply that.
Regards
Greg
>>> ---
>>>
>>> Changes:
>>> V2: This patch is now independant from the previous one
>>>
>>> arch/m68k/include/asm/m54xxacr.h | 10 +++++++---
>>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/arch/m68k/include/asm/m54xxacr.h
>>> b/arch/m68k/include/asm/m54xxacr.h
>>> index 192bbfe..8f932be 100644
>>> --- a/arch/m68k/include/asm/m54xxacr.h
>>> +++ b/arch/m68k/include/asm/m54xxacr.h
>>> @@ -94,14 +94,18 @@
>>> * register region as non-cacheable. And then we map all our RAM as
>>> * cacheable and supervisor access only.
>>> */
>>> -#define ACR0_MODE (ACR_BA(CONFIG_MBAR)+ACR_ADMSK(0x1000000)+ \
>>> +#define ACR0_MODE (ACR_BA(CONFIG_MBAR)+ACR_ADMSK(0x1000000)+ \
>>> ACR_ENABLE+ACR_SUPER+ACR_CM_OFF_PRE+ACR_SP)
>>> +#if defined(CONFIG_CACHE_COPYBACK)
>>> #define ACR1_MODE (ACR_BA(CONFIG_RAMBASE)+ACR_ADMSK(CONFIG_RAMSIZE)+ \
>>> - ACR_ENABLE+ACR_SUPER+ACR_SP)
>>> + ACR_ENABLE+ACR_SUPER+ACR_SP+ACR_CM_CP)
>>> +#else
>>> +#define ACR1_MODE (ACR_BA(CONFIG_RAMBASE)+ACR_ADMSK(CONFIG_RAMSIZE)+ \
>>> + ACR_ENABLE+ACR_SUPER+ACR_SP+ACR_CM_WT)
>>> +#endif
>>> #define ACR2_MODE 0
>>> #define ACR3_MODE (ACR_BA(CONFIG_RAMBASE)+ACR_ADMSK(CONFIG_RAMSIZE)+ \
>>> ACR_ENABLE+ACR_SUPER+ACR_SP)
>>> -
>>> #else
>>>
>>> /*
>>> --
>>> 1.7.9.5
>
>
>
--
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close, FAX: +61 7 3891 3630
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
next prev parent reply other threads:[~2012-10-16 12:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-15 12:54 [PATCH 1/4] Add linux/io.h to make it compile Stany MARCEL
2012-10-15 12:54 ` [PATCH 2/4] Permit to read/write to shared page Stany MARCEL
2012-10-15 12:54 ` [PATCH 3/4] Add for MCF54xx a virtual non cached zone usable for data exchange with DMA Stany MARCEL
2012-10-15 13:22 ` [PATCH 3/4 V2] " Stany MARCEL
2012-10-16 5:15 ` Greg Ungerer
2012-10-16 10:46 ` Stany MARCEL
2012-10-16 11:23 ` Philippe De Muyter
2012-10-16 12:29 ` Greg Ungerer
2012-10-16 13:57 ` RE : " Stany MARCEL
2012-10-15 12:54 ` [PATCH 4/4] Set ACR1 cache mode depending on kernel configuration Stany MARCEL
2012-10-15 13:22 ` [PATCH 4/4 V2] " Stany MARCEL
2012-10-16 5:27 ` Greg Ungerer
2012-10-16 8:12 ` Philippe De Muyter
2012-10-16 12:06 ` Greg Ungerer [this message]
2012-10-15 13:58 ` [PATCH 1/4] Add linux/io.h to make it compile Philippe De Muyter
2012-10-15 14:06 ` Stany MARCEL
2012-10-15 14:39 ` Philippe De Muyter
2012-10-16 4:58 ` Greg Ungerer
2012-10-15 14:08 ` [PATCH 1/4 V2] Add linux/io.h to make m54xx_wdt.c compile with MMU enabled Stany MARCEL
2012-10-16 5:04 ` Greg Ungerer
2012-10-16 10:47 ` Stany MARCEL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507D4DCF.6050304@snapgear.com \
--to=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
--cc=phdm@macqel.be \
--cc=stany.marcel@novasys-ingenierie.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.