All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] am33xx: move ti i2c baseboard header handling to board/ti/am335x/evm.{c, h}
Date: Tue, 16 Oct 2012 08:35:11 -0700	[thread overview]
Message-ID: <507D7EAF.5080000@ti.com> (raw)
In-Reply-To: <1350400526-21714-2-git-send-email-peter.korsgaard@barco.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/16/12 08:15, Peter Korsgaard wrote:
> The i2c header is specific to ti(-derived) boards, and not generic
> for all am335x boards.
> 
> Signed-off-by: Peter Korsgaard <peter.korsgaard@barco.com> --- 
> arch/arm/cpu/armv7/am33xx/board.c                  |  235
> -------------------- arch/arm/include/asm/arch-am33xx/sys_proto.h
> |   27 --- board/ti/am335x/Makefile                           |
> 1 + .../armv7/am33xx/board.c => board/ti/am335x/evm.c  |   33 +-- 
> .../sys_proto.h => board/ti/am335x/evm.h           |   24 +- 
> board/ti/am335x/mux.c                              |    1 + 6 files
> changed, 10 insertions(+), 311 deletions(-) copy
> arch/arm/cpu/armv7/am33xx/board.c => board/ti/am335x/evm.c (90%) 
> copy arch/arm/include/asm/arch-am33xx/sys_proto.h =>
> board/ti/am335x/evm.h (75%)

I'd like to see it as board/ti/am33xx/board.[ch] but other than that I
can see where you're coming from.  Can you post a WIP version of your
s_init / board_init?  I'd like to see what maybe we should call __weak
or try and restructure a bit more.  Thanks!

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iQIcBAEBAgAGBQJQfX6vAAoJENk4IS6UOR1W6h0QAIhAoLVANPWvrtH+MP5S6WBD
G4kqyaefd0AJmCNX9CXMT+Qx/rjMqM/bPr047K80xj0XpC3GLaGMiZJbnjXoFwcg
bm0hd3ogK9AeSReONsMjk5qndLtBEfVniGDPi33atzimEUjsHYZdc9zR0SbP7+il
7n8YlZQoCH6KytZNn1/REXQQfs1ZY+zRA5uUxgqIpejCBTjoQXItQ1zURXUftD76
Rufk4vzEEvSVeQ/RIW3xhSLPzUTLjI1dBfZOgK5tzCb5ltxE9C8bOpIqt+ISuh73
1nLsJnxDQF5TR1WHyyX8yIN8FVow/eglaHCfi3y0NZdkRiFWlkN+rhL+XqNIOfiP
/ddZ41Vo5oA5t4wxWktd+GN6gSEivfjPw8m8EoJCSNdBgZi1yDD8YPshVcVQm29f
EiHOi1ZOzCkWk5m12XVRl32LxtikEOjb2Icw2tjZ187s4Ow3S3H6+dseRKkgqxk8
WrnVt64mr8LimdeEZShWOcm+0iFMAdYzmmHmtGL+8lqyeAPoHIQ0LGRnjNarbtXJ
EAcremyRzIgtnMGMDwDpWczXoH+sYfPaNSzT9tJ39quWkn5f7KLU5zC40BnxkAjh
0fxmdec6TN2a29sfPL3fXiD1e7Nvirem8jJrOcNyP90fGx3cwfRkNrQgLitYpY/w
VtncBdacDWaqaTtSGDlR
=4apt
-----END PGP SIGNATURE-----

  reply	other threads:[~2012-10-16 15:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-16 15:15 [U-Boot] [PATCH 0/5] am33xx: support non-ti boards Peter Korsgaard
2012-10-16 15:15 ` [U-Boot] [PATCH 1/5] am33xx: move ti i2c baseboard header handling to board/ti/am335x/evm.{c, h} Peter Korsgaard
2012-10-16 15:35   ` Tom Rini [this message]
2012-10-17 15:46     ` Peter Korsgaard
2012-10-17 15:55       ` Tom Rini
2012-10-17 19:24         ` Peter Korsgaard
2012-10-16 15:15 ` [U-Boot] [PATCH 2/5] am335x/evm.c: don't make wdtimer/uart_base global Peter Korsgaard
2012-10-16 15:15 ` [U-Boot] [PATCH 3/5] am33xx/board: use cpu_mmc_init() for default mmc initialization Peter Korsgaard
2012-10-16 15:36   ` Tom Rini
2012-10-16 17:37     ` Peter Korsgaard
2012-10-16 15:15 ` [U-Boot] [PATCH 4/5] am33xx: move generic parts of pinmux handling out from board/ti/am335x Peter Korsgaard
2012-10-16 15:15 ` [U-Boot] [PATCH 5/5] am33xx: support board specific ddr settings Peter Korsgaard
2012-10-16 15:31   ` Tom Rini
2012-10-16 17:43     ` Peter Korsgaard
2012-10-16 21:13       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507D7EAF.5080000@ti.com \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.