From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
Drew Jones <drjones@redhat.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: PV passthrough of sibling igbvf's
Date: Tue, 16 Oct 2012 16:37:46 +0100 [thread overview]
Message-ID: <507D7F4A.8020409@citrix.com> (raw)
In-Reply-To: <507D7774.2050902@redhat.com>
On 16/10/12 16:04, Laszlo Ersek wrote:
> A closer pointer into the changeset:
>
> http://xenbits.xensource.com/xen-unstable.hg/rev/5b433b4fca34#l16.85
>
> The patch doesn't seem to justify the grouping specifically, thus I did
> not even try to refute it.
>
> Now that you point it out, match_slot() is probably insufficient grounds
> to group functions together. Maybe we should check *additionally* if the
> device being passed through is multi-function. I'll try it.
While that would hopefully solve the bug you have discovered, it does
raise some more queries.
What should we do when passing through only the first function of a
multifunction device, specifically in reference to domain
disagregation? I would like to hope things would just work, but I am
somewhat doubtful.
For SRIOV hardware, passing the physical function through should be fine
(even though it is a multifunction device), as it is specifically
designed to work in this way. For a CNA however, the chances of getting
it working at all with different functions in different domains is
unlikely at best.
I just wanted to put these thoughts out in case anyone has any bright
ideas about how to solve them.
~Andrew
>
> Thanks!
> Laszlo
--
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com
next prev parent reply other threads:[~2012-10-16 15:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 14:21 PV passthrough of sibling igbvf's Laszlo Ersek
2012-10-16 14:42 ` Andrew Cooper
2012-10-16 15:04 ` Laszlo Ersek
2012-10-16 15:37 ` Andrew Cooper [this message]
2012-10-16 17:36 ` [PATCH] xen PV passthru: assign SR-IOV virtual functions to separate virtual slots Laszlo Ersek
2012-10-17 7:13 ` Jan Beulich
2012-10-17 9:55 ` [PATCH v2] " Laszlo Ersek
2012-10-17 10:01 ` Jan Beulich
2012-10-17 14:51 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507D7F4A.8020409@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=drjones@redhat.com \
--cc=imammedo@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=lersek@redhat.com \
--cc=pbonzini@redhat.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.