From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TODcs-000584-Ho for qemu-devel@nongnu.org; Tue, 16 Oct 2012 16:20:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TODcr-0006PS-2O for qemu-devel@nongnu.org; Tue, 16 Oct 2012 16:20:30 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:50390) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TODcq-0006PI-S1 for qemu-devel@nongnu.org; Tue, 16 Oct 2012 16:20:28 -0400 Message-ID: <507DC189.4060107@weilnetz.de> Date: Tue, 16 Oct 2012 22:20:25 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1350244839-16875-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] configure: Disable (clang) initializer-overrides warnings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Blue Swirl , qemu-devel@nongnu.org, patches@linaro.org Am 14.10.2012 22:24, schrieb Peter Maydell: > On 14 October 2012 21:15, Blue Swirl wrote: >> On Sun, Oct 14, 2012 at 8:00 PM, Peter Maydell wrote: >>> Blue Swirl previously submitted a patch which enabled this flag >>> (among others): >>> http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg04203.html >> >> In my version, Clang flags were separate from GCC flags. I think it >> would be better to run different tests for each compiler in the >> future, that lets GCC avoid Clang flag -ffoobar which does not have >> desirable effect to GCC and vice versa. > > Mmm, but at the moment it's entirely fine to pass both compilers > the same flags, and moreover we actually pass all these flags > to the compiler without checking if it's gcc or not; we just > ask if the compiler will run OK with the flag passed. (I'm not > even sure how you'd determine whether your compiler was gcc > or clang or gcc-llvm or whatever...) > >> I'd also like to handle flags for sparse checker the same way. > > I agree that those bits of configure could be cleaner. > > -- PMM > Hi Peter, hi Blue, gcc uses a different flag -Wno-override-init to disable initializer override warnings. I tested the following patch which uses -Wextra with gcc-4.4 and gcc-4.7. It allows compilation of QEMU without warnings. A test with those flags and clang still has to be done. Regards Stefan W. diff --git a/configure b/configure index 359e453..0818eda 100755 --- a/configure +++ b/configure @@ -267,6 +267,8 @@ sdl_config="${SDL_CONFIG-${cross_prefix}sdl-config}" QEMU_CFLAGS="-fno-strict-aliasing $QEMU_CFLAGS" QEMU_CFLAGS="-Wall -Wundef -Wwrite-strings -Wmissing-prototypes $QEMU_CFLAGS" QEMU_CFLAGS="-Wstrict-prototypes -Wredundant-decls $QEMU_CFLAGS" +QEMU_CFLAGS="-Wextra -Wno-missing-field-initializers $QEMU_CFLAGS" +QEMU_CFLAGS="-Wno-override-init -Wno-sign-compare -Wno-unused-parameter $QEMU_CFLAGS" QEMU_CFLAGS="-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE $QEMU_CFLAGS" QEMU_INCLUDES="-I. -I\$(SRC_PATH) -I\$(SRC_PATH)/fpu" if test "$debug_info" = "yes"; then