All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] ARM: tegra: increase CONFIG_SYS_TEXT_BASE
Date: Tue, 16 Oct 2012 16:43:30 -0600	[thread overview]
Message-ID: <507DE312.60003@wwwdotorg.org> (raw)
In-Reply-To: <1350425362.3502.28.camel@tellur>

On 10/16/2012 04:09 PM, Lucas Stach wrote:
> Am Dienstag, den 16.10.2012, 15:50 -0600 schrieb Stephen Warren:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> The SPL has grown. Increase CONFIG_SYS_TEXT_BASE so SPL's BSS does not
>> overlap the main U-Boot.
>
> Is there any specific reason why the SPL is now bigger than before? Or
> is this just because of the general U-Boot rework (like serial multi
> anywhere)? And by how much has it grown? This is really more out of
> curiosity rather than any real objection.

Looking at this more, I built commit cca6076 "tegra20: Remove armv4t
build flags" which was the last patch in the series that enabled SPL on
Tegra, and it overflows even there:

Configuring for ventana board...
   text	   data	    bss	    dec	    hex	filename
 226085	   4384	 274228	 504697	  7b379	./u-boot
  13857	    153	   4516	  18526	   485e	./spl/u-boot-spl

u-boot/master currently has:

Configuring for ventana board...
   text	   data	    bss	    dec	    hex	filename
 233579	   4432	 274368	 512379	  7d17b	./u-boot
  14382	    201	   4520	  19103	   4a9f	./spl/u-boot-spl

So, there is slight growth, but mainly I think we've just been getting
lucky.

Also, the overflow might possibly only have been exposed by the recent
serial rework; when I found the problem the serial rework caused on
Tegra, Allen mentioned that the missing BSS clearing hadn't been a
problem before since no global variables were used, but the serial
rework caused some to be.

  reply	other threads:[~2012-10-16 22:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-16 21:50 [U-Boot] [PATCH 1/4] ARM: fix u-boot.lds for -ffunction-sections/-fdata-sections Stephen Warren
2012-10-16 21:50 ` [U-Boot] [PATCH 2/4] ARM: tegra: combine duplicate Makefile rules Stephen Warren
2012-10-18  0:01   ` Simon Glass
2012-10-16 21:50 ` [U-Boot] [PATCH 3/4] ARM: tegra: check for SPL size overflow in makefile Stephen Warren
2012-10-18  0:03   ` Simon Glass
2012-10-18  3:18     ` Stephen Warren
2012-10-18 16:27   ` Tom Rini
2012-10-18 20:45     ` Stephen Warren
2012-10-18 20:50       ` Tom Rini
2012-10-16 21:50 ` [U-Boot] [PATCH 4/4] ARM: tegra: increase CONFIG_SYS_TEXT_BASE Stephen Warren
2012-10-16 22:09   ` Lucas Stach
2012-10-16 22:43     ` Stephen Warren [this message]
2012-10-18  0:05       ` Simon Glass
2012-10-18  3:20         ` Stephen Warren
2012-10-18 16:31           ` Tom Rini
2012-10-18 20:42             ` Stephen Warren
2012-10-17 23:58 ` [U-Boot] [PATCH 1/4] ARM: fix u-boot.lds for -ffunction-sections/-fdata-sections Simon Glass
2012-10-18  3:17   ` Stephen Warren
2012-10-18 20:36     ` Albert ARIBAUD
2012-10-18 20:58       ` Stephen Warren
2012-10-18 21:17         ` Stephen Warren
2012-10-20 10:31           ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507DE312.60003@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.