From: "Christian König" <deathsimple@vodafone.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: drivers/gpu/drm/radeon/radeon_gart.c:580:5: sparse: symbol 'radeon_vm_evict' was not declared. S
Date: Wed, 17 Oct 2012 09:26:01 +0000 [thread overview]
Message-ID: <507E79A9.7040604@vodafone.de> (raw)
In-Reply-To: <20121017064444.GA17885@localhost>
Hi Fengguang,
yes that's correct the function should be static.
Cheers,
Christian.
On 17.10.2012 08:44, Fengguang Wu wrote:
> Hi Christian,
>
> FYI, there are new sparse warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux master
> head: 8d2b6b3ae280dcf6f6c7a95623670a57cdf562ed
> commit: 90a51a329258e3c868f6f4c1fb264ca01c590c57 drm/radeon: allocate page tables on demand v4
> date: 2 days ago
>
> + drivers/gpu/drm/radeon/radeon_gart.c:580:5: sparse: symbol 'radeon_vm_evict' was not declared. Should it be static?
>
> vim +580 drivers/gpu/drm/radeon/radeon_gart.c
>
> 09db8644 Alex Deucher 2012-07-17 569 /**
> 90a51a32 Christian König 2012-10-09 570 * radeon_vm_evict - evict page table to make room for new one
> 90a51a32 Christian König 2012-10-09 571 *
> 90a51a32 Christian König 2012-10-09 572 * @rdev: radeon_device pointer
> 90a51a32 Christian König 2012-10-09 573 * @vm: VM we want to allocate something for
> 90a51a32 Christian König 2012-10-09 574 *
> 90a51a32 Christian König 2012-10-09 575 * Evict a VM from the lru, making sure that it isn't @vm. (cayman+).
> 90a51a32 Christian König 2012-10-09 576 * Returns 0 for success, -ENOMEM for failure.
> 90a51a32 Christian König 2012-10-09 577 *
> 90a51a32 Christian König 2012-10-09 578 * Global and local mutex must be locked!
> 90a51a32 Christian König 2012-10-09 579 */
> 90a51a32 Christian König 2012-10-09 @580 int radeon_vm_evict(struct radeon_device *rdev, struct radeon_vm *vm)
> 90a51a32 Christian König 2012-10-09 581 {
> 90a51a32 Christian König 2012-10-09 582 struct radeon_vm *vm_evict;
> 90a51a32 Christian König 2012-10-09 583
> 90a51a32 Christian König 2012-10-09 584 if (list_empty(&rdev->vm_manager.lru_vm))
> 90a51a32 Christian König 2012-10-09 585 return -ENOMEM;
> 90a51a32 Christian König 2012-10-09 586
> 90a51a32 Christian König 2012-10-09 587 vm_evict = list_first_entry(&rdev->vm_manager.lru_vm,
> 90a51a32 Christian König 2012-10-09 588 struct radeon_vm, list);
>
> Shall we apply the attached diff?
>
> Thanks,
> Fengguang
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-10-17 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 6:44 drivers/gpu/drm/radeon/radeon_gart.c:580:5: sparse: symbol 'radeon_vm_evict' was not declared. Shoul Fengguang Wu
2012-10-17 9:26 ` Christian König [this message]
2012-10-17 16:41 ` drivers/gpu/drm/radeon/radeon_gart.c:580:5: sparse: symbol 'radeon_vm_evict' was not declared. S Deucher, Alexander
2012-10-17 16:55 ` Fengguang Wu
2012-10-17 16:56 ` Deucher, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507E79A9.7040604@vodafone.de \
--to=deathsimple@vodafone.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.