From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 0/4] block-commit fixes
Date: Wed, 17 Oct 2012 11:46:41 +0200 [thread overview]
Message-ID: <507E7E81.4070802@redhat.com> (raw)
In-Reply-To: <507DC47E.9050505@redhat.com>
Am 16.10.2012 22:33, schrieb Eric Blake:
> On 10/16/2012 01:49 PM, Jeff Cody wrote:
>> v2 -> v3 differences:
>>
>> * Simplified code in patch 2, minor commit rewording
>> * Made conditional check more valgrind-friendly
>>
>> v1 -> v2 differences:
>>
>> * Updated changes to be protocol friendly
>> * Updated block-commit tests to account for different error message
>> wording
>> * Updated block-commit tests to add relative backing filename tests
>> * In bdrv_find_backing_image(), use g_malloc() instead of char arrays
>>
>>
>> Jeff Cody (4):
>> block: make bdrv_find_backing_image compare canonical filenames
>> block: in commit, determine base image from the top image
>> qemu-iotests: qemu-io tests update for block-commit (040)
>> qemu-iotests: add relative backing file tests for block-commit (040)
>
> Should patch 3/4 be squashed into 2/4 to avoid 'git bisect' failures
> when running the testsuite? Other than that, series:
Yes, I agree. Applied all and squashed 3/4 into 2/4.
Kevin
prev parent reply other threads:[~2012-10-17 9:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 19:49 [Qemu-devel] [PATCH v3 0/4] block-commit fixes Jeff Cody
2012-10-16 19:49 ` [Qemu-devel] [PATCH v3 1/4] block: make bdrv_find_backing_image compare canonical filenames Jeff Cody
2012-10-16 19:49 ` [Qemu-devel] [PATCH v3 2/4] block: in commit, determine base image from the top image Jeff Cody
2012-10-16 19:49 ` [Qemu-devel] [PATCH v3 3/4] qemu-iotests: qemu-io tests update for block-commit (040) Jeff Cody
2012-10-16 19:49 ` [Qemu-devel] [PATCH v3 4/4] qemu-iotests: add relative backing file tests " Jeff Cody
2012-10-16 20:33 ` [Qemu-devel] [PATCH v3 0/4] block-commit fixes Eric Blake
2012-10-17 9:46 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507E7E81.4070802@redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.