From: Vlad Yasevich <vyasevic@redhat.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCHv3] ipv6: Enable enough of the code to handle GSO when disabled.
Date: Wed, 17 Oct 2012 15:03:15 -0400 [thread overview]
Message-ID: <507F00F3.4000305@redhat.com> (raw)
In-Reply-To: <1350492636.2884.5.camel@bwh-desktop.uk.solarflarecom.com>
On 10/17/2012 12:50 PM, Ben Hutchings wrote:
> On Wed, 2012-10-17 at 18:13 +0200, Eric Dumazet wrote:
>> On Wed, 2012-10-17 at 11:46 -0400, Vlad Yasevich wrote:
>>
>>> This patch attempts to solve this by enabling just enough code so GSO
>>> is correctly processed. However, I should point out that if IPv6 is
>>> simply blacklisted or not built for the kernel, this problem will
>>> still persist.
>>
>> So I guess this should be done in a different way ?
>>
>> We currently use a single structure (struct packet_type) to hold
>> pointers to different methods. (The .func() field, and the gso/gro
>> stuff)
>>
>> We probably need to split it in two parts, and make one part linked into
>> kernel, even if CONFIG_IPV6=n, so that GRO/GSO is fully IPv4/IPv6
>> functional.
> [...]
>
> Either that or make sure that we don't advertise IPv6 GSO when IPv6 is
> disabled.
>
> Ben.
>
this becomes a problem when migration or save/restore is used. since
offload features may be different between systesm, we may not be able to
migrate.
-vlad
next prev parent reply other threads:[~2012-10-17 19:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 15:46 [PATCHv3] ipv6: Enable enough of the code to handle GSO when disabled Vlad Yasevich
2012-10-17 16:13 ` Eric Dumazet
2012-10-17 16:50 ` Ben Hutchings
2012-10-17 19:03 ` Vlad Yasevich [this message]
2012-10-17 19:11 ` Vlad Yasevich
2012-10-17 19:33 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=507F00F3.4000305@redhat.com \
--to=vyasevic@redhat.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.