From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <507FA214.3010505@siemens.com> Date: Thu, 18 Oct 2012 08:30:44 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <507E9424.8060800@siemens.com> <507F876F.7080406@xenomai.org> <507F9D8F.8050309@siemens.com> <507F9FD0.1070407@xenomai.org> In-Reply-To: <507F9FD0.1070407@xenomai.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Xenomai] [PATCH] nucleus: Convert intrlock to a sleeping Linux lock List-Id: Discussions about the Xenomai project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gilles Chanteperdrix Cc: Xenomai On 2012-10-18 08:21, Gilles Chanteperdrix wrote: > On 10/18/2012 08:11 AM, Jan Kiszka wrote: >> On 2012-10-18 06:37, Gilles Chanteperdrix wrote: >>> On 10/17/2012 01:19 PM, Jan Kiszka wrote: >>> >>>> All users of this lock are supposed to run over Linux context already. >>>> Moreover, latest I-pipe patches complain that ipipe_virtualize_irq is >>>> called with the Xenomai domain stalled. So convert this lock to a >>>> sleeping Linux variant to avoid that alarm. >>> >>> >>> Do we really really want such a change in the stable branch? >> >> Yes because it fixes a bug (that prevents detecting other bugs). > > The commit log (quoted above) does not say that. I can improve that. > It says that it fixes a > warning which really looks like a false positive, and that could be > disabled when compiling legacy versions of Xenomai. Nope as the warning is system wide. And we depend on that self-check to stabilize I-pipe and Xenomai over new kernel versions. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux