All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Johansen <john.johansen@canonical.com>
To: Hiromu Yakura <hiromu1996@gmail.com>
Cc: linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	James Morris <james.l.morris@oracle.com>
Subject: Re: [PATCH] AppArmor: Modify Makefile to avoid Oops
Date: Thu, 18 Oct 2012 01:01:19 -0700	[thread overview]
Message-ID: <507FB74F.1010104@canonical.com> (raw)
In-Reply-To: <38590271.RTeeX2bDYV@hiromu-macbook>

On 10/18/2012 12:19 AM, Hiromu Yakura wrote:
> In my environment, AppArmor cause Oops every time when cupsd launch.
> 
> This is the log of Oops:
> [  114.876511] general protection fault: 0000 [#1] SMP 

<snip>

> It seems that bad address was passed for the second argument of 
> audit_log_untrustedstring() at audit_cb() in capability.c:
>  52     audit_log_untrustedstring(ab, capability_names[sa->u.cap]);
> 
> The array "capability_names" is defined in capability_names.h but the content 
> of this is generated by Makefile from include/linux/capability.h
> However, capability.h was moved to include/uapi/linux/capability.h and because 
> of this, the array is empty.
> That's why, sa->u.cap become out of range this and segmentation fault caused.
> 
> Let's fix it.
> 
> Cc: James Morris <james.l.morris@oracle.com>
> Cc: John Johansen <john.johansen@canonical.com>
> 
Thanks Hiromu,

but this was fixed a few hours ago
http://marc.info/?t=135050396600008&r=1&w=2



      reply	other threads:[~2012-10-18  8:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-18  7:19 [PATCH] AppArmor: Modify Makefile to avoid Oops Hiromu Yakura
2012-10-18  8:01 ` John Johansen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507FB74F.1010104@canonical.com \
    --to=john.johansen@canonical.com \
    --cc=hiromu1996@gmail.com \
    --cc=james.l.morris@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.