From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benoit Cousson Subject: Re: [PATCH] ARM: dts: AM33XX: Add tsl2550 ambient light sensor DT data Date: Thu, 18 Oct 2012 10:08:30 +0200 Message-ID: <507FB8FE.6010003@ti.com> References: <1348242551-21293-1-git-send-email-anilkumar@ti.com> <331ABD5ECB02734CA317220B2BBEABC13EA53C2B@DBDE01.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:35367 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752633Ab2JRIIg (ORCPT ); Thu, 18 Oct 2012 04:08:36 -0400 In-Reply-To: <331ABD5ECB02734CA317220B2BBEABC13EA53C2B@DBDE01.ent.ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "AnilKumar, Chimata" Cc: "tony@atomide.com" , "linux-arm-kernel@lists.infradead.org" , "linux-omap@vger.kernel.org" Hi Anil, On 10/18/2012 07:46 AM, AnilKumar, Chimata wrote: > On Fri, Sep 21, 2012 at 21:19:11, AnilKumar, Chimata wrote: >> Add tsl2550 ambient light sensor DT data to am335x-evm.dts. In AM335x >> EVM tsl2550 ambient light sensor is connected to I2C2 bus. So this patch >> adds child node inside i2c2 node with i2c slave address. >> >> TAOS tsl2550 sensor with two-wire SMBus serial interface. This patch >> also reduces I2C2 clock frequency to 100KHz from 400KHz because the >> maximum clock frequency of SMBus is 100KHz. >> >> Signed-off-by: AnilKumar Ch >> --- >> arch/arm/boot/dts/am335x-evm.dts | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts >> index 3b1f313..d99aa0f 100644 >> --- a/arch/arm/boot/dts/am335x-evm.dts >> +++ b/arch/arm/boot/dts/am335x-evm.dts >> @@ -49,7 +49,7 @@ >> >> i2c2: i2c@4802a000 { >> status = "okay"; >> - clock-frequency = <400000>; >> + clock-frequency = <100000>; >> >> lis331dlh: lis331dlh@18 { >> compatible = "st,lis331dlh", "st,lis3lv02d"; >> @@ -79,6 +79,11 @@ >> st,max-limit-z = <750>; >> }; >> >> + tsl2550: tsl2550@39 { >> + compatible = "taos,tsl2550"; >> + reg = <0x39>; >> + }; >> + >> tmp275: tmp275@48 { >> compatible = "ti,tmp275"; >> reg = <0x48>; > > Hi Tony/Benoit, > > If there are no comments in this patch could you please take this in? Have you updated the binding documentation to list the device? It should be in: Documentation/devicetree/bindings/i2c/trivial-devices.txt Please Cc as well the DT ml. Regards, Benoit From mboxrd@z Thu Jan 1 00:00:00 1970 From: b-cousson@ti.com (Benoit Cousson) Date: Thu, 18 Oct 2012 10:08:30 +0200 Subject: [PATCH] ARM: dts: AM33XX: Add tsl2550 ambient light sensor DT data In-Reply-To: <331ABD5ECB02734CA317220B2BBEABC13EA53C2B@DBDE01.ent.ti.com> References: <1348242551-21293-1-git-send-email-anilkumar@ti.com> <331ABD5ECB02734CA317220B2BBEABC13EA53C2B@DBDE01.ent.ti.com> Message-ID: <507FB8FE.6010003@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Anil, On 10/18/2012 07:46 AM, AnilKumar, Chimata wrote: > On Fri, Sep 21, 2012 at 21:19:11, AnilKumar, Chimata wrote: >> Add tsl2550 ambient light sensor DT data to am335x-evm.dts. In AM335x >> EVM tsl2550 ambient light sensor is connected to I2C2 bus. So this patch >> adds child node inside i2c2 node with i2c slave address. >> >> TAOS tsl2550 sensor with two-wire SMBus serial interface. This patch >> also reduces I2C2 clock frequency to 100KHz from 400KHz because the >> maximum clock frequency of SMBus is 100KHz. >> >> Signed-off-by: AnilKumar Ch >> --- >> arch/arm/boot/dts/am335x-evm.dts | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts >> index 3b1f313..d99aa0f 100644 >> --- a/arch/arm/boot/dts/am335x-evm.dts >> +++ b/arch/arm/boot/dts/am335x-evm.dts >> @@ -49,7 +49,7 @@ >> >> i2c2: i2c at 4802a000 { >> status = "okay"; >> - clock-frequency = <400000>; >> + clock-frequency = <100000>; >> >> lis331dlh: lis331dlh at 18 { >> compatible = "st,lis331dlh", "st,lis3lv02d"; >> @@ -79,6 +79,11 @@ >> st,max-limit-z = <750>; >> }; >> >> + tsl2550: tsl2550 at 39 { >> + compatible = "taos,tsl2550"; >> + reg = <0x39>; >> + }; >> + >> tmp275: tmp275 at 48 { >> compatible = "ti,tmp275"; >> reg = <0x48>; > > Hi Tony/Benoit, > > If there are no comments in this patch could you please take this in? Have you updated the binding documentation to list the device? It should be in: Documentation/devicetree/bindings/i2c/trivial-devices.txt Please Cc as well the DT ml. Regards, Benoit