From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: do not de-cache cr4 bits needlessly Date: Thu, 18 Oct 2012 14:49:40 +0200 Message-ID: <507FFAE4.8000109@redhat.com> References: <20121015074907.GB20788@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, mtosatti@redhat.com To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:64117 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755022Ab2JRMto (ORCPT ); Thu, 18 Oct 2012 08:49:44 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9ICniFk011907 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Oct 2012 08:49:44 -0400 In-Reply-To: <20121015074907.GB20788@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/15/2012 09:49 AM, Gleb Natapov wrote: > > Signed-off-by: Gleb Natapov > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index e9c83b1..3df12c8 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -635,7 +635,7 @@ int kvm_set_cr3(struct kvm_vcpu *vcpu, unsigned long cr3) > } > > if (is_long_mode(vcpu)) { > - if (kvm_read_cr4(vcpu) & X86_CR4_PCIDE) { > + if (kvm_read_cr4_bits(vcpu, X86_CR4_PCIDE)) { > if (cr3 & CR3_PCID_ENABLED_RESERVED_BITS) > return 1; > } else Applied, thanks. -- error compiling committee.c: too many arguments to function