From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1TOsfT-0002qc-GN for mharc-qemu-trivial@gnu.org; Thu, 18 Oct 2012 12:09:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59410) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOsfI-0002M5-Tc for qemu-trivial@nongnu.org; Thu, 18 Oct 2012 12:09:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOsfD-0008HQ-1G for qemu-trivial@nongnu.org; Thu, 18 Oct 2012 12:09:44 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:48187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOsf3-0008Ex-Px; Thu, 18 Oct 2012 12:09:29 -0400 Received: from localhost (v220110690675601.yourvserver.net.local [127.0.0.1]) by v220110690675601.yourvserver.net (Postfix) with ESMTP id 286F57280041; Thu, 18 Oct 2012 18:09:28 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at weilnetz.de Received: from v220110690675601.yourvserver.net ([127.0.0.1]) by localhost (v220110690675601.yourvserver.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P4q8kDLCnuFD; Thu, 18 Oct 2012 18:09:27 +0200 (CEST) Received: from [192.168.178.20] (p5086EFF2.dip.t-dialin.net [80.134.239.242]) by v220110690675601.yourvserver.net (Postfix) with ESMTPSA id 3CF2F728003B; Thu, 18 Oct 2012 18:09:27 +0200 (CEST) Message-ID: <508029B6.8060301@weilnetz.de> Date: Thu, 18 Oct 2012 18:09:26 +0200 From: Stefan Weil User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 MIME-Version: 1.0 To: Peter Maydell References: <1350572612-24268-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1350572612-24268-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 78.47.199.172 Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] ui/vnc-jobs.c: Fix minor typos in comments X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2012 16:09:53 -0000 Please see my comments below. Am 18.10.2012 17:03, schrieb Peter Maydell: > Fix some minor typos/grammar errors in comments. > > Signed-off-by: Peter Maydell > --- > ui/vnc-jobs.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c > index 087b84d..84b074e 100644 > --- a/ui/vnc-jobs.c > +++ b/ui/vnc-jobs.c > @@ -33,21 +33,21 @@ > /* > * Locking: > * > - * There is three levels of locking: > + * There are three levels of locking: > * - jobs queue lock: for each operation on the queue (push, pop, isEmpty?) > * - VncDisplay global lock: mainly used for framebuffer updates to avoid > * screen corruption if the framebuffer is updated > - * while the worker is doing something. > + * while the worker is doing something. > * - VncState::output lock: used to make sure the output buffer is not corrupted > - * if two threads try to write on it at the same time > + * two threads try to write on it at the same time Did you remove the 'if' intentionally? Then I'd expect a comma after 'corrupted', because 'two threads try to write ...' is a new sentence. > * > - * While the VNC worker thread is working, the VncDisplay global lock is hold > - * to avoid screen corruptions (this does not block vnc_refresh() because it > - * uses trylock()) but the output lock is not hold because the thread work on > + * While the VNC worker thread is working, the VncDisplay global lock is held > + * to avoid screen corruption (this does not block vnc_refresh() because it > + * uses trylock()) but the output lock is not held because the thread works on > * its own output buffer. > * When the encoding job is done, the worker thread will hold the output lock > * and copy its output buffer in vs->output. > -*/ > + */ > > struct VncJobQueue { > QemuCond cond; > @@ -62,7 +62,7 @@ typedef struct VncJobQueue VncJobQueue; > > /* > * We use a single global queue, but most of the functions are > - * already reetrant, so we can easilly add more than one encoding thread > + * already reentrant, so we can easily add more than one encoding thread > */ > static VncJobQueue *queue; Reviewed-by: Stefan Weil Cheers Stefan From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TOsf8-00026A-Jv for qemu-devel@nongnu.org; Thu, 18 Oct 2012 12:09:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TOsf4-0008F9-0c for qemu-devel@nongnu.org; Thu, 18 Oct 2012 12:09:34 -0400 Message-ID: <508029B6.8060301@weilnetz.de> Date: Thu, 18 Oct 2012 18:09:26 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1350572612-24268-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1350572612-24268-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ui/vnc-jobs.c: Fix minor typos in comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org Please see my comments below. Am 18.10.2012 17:03, schrieb Peter Maydell: > Fix some minor typos/grammar errors in comments. > > Signed-off-by: Peter Maydell > --- > ui/vnc-jobs.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c > index 087b84d..84b074e 100644 > --- a/ui/vnc-jobs.c > +++ b/ui/vnc-jobs.c > @@ -33,21 +33,21 @@ > /* > * Locking: > * > - * There is three levels of locking: > + * There are three levels of locking: > * - jobs queue lock: for each operation on the queue (push, pop, isEmpty?) > * - VncDisplay global lock: mainly used for framebuffer updates to avoid > * screen corruption if the framebuffer is updated > - * while the worker is doing something. > + * while the worker is doing something. > * - VncState::output lock: used to make sure the output buffer is not corrupted > - * if two threads try to write on it at the same time > + * two threads try to write on it at the same time Did you remove the 'if' intentionally? Then I'd expect a comma after 'corrupted', because 'two threads try to write ...' is a new sentence. > * > - * While the VNC worker thread is working, the VncDisplay global lock is hold > - * to avoid screen corruptions (this does not block vnc_refresh() because it > - * uses trylock()) but the output lock is not hold because the thread work on > + * While the VNC worker thread is working, the VncDisplay global lock is held > + * to avoid screen corruption (this does not block vnc_refresh() because it > + * uses trylock()) but the output lock is not held because the thread works on > * its own output buffer. > * When the encoding job is done, the worker thread will hold the output lock > * and copy its output buffer in vs->output. > -*/ > + */ > > struct VncJobQueue { > QemuCond cond; > @@ -62,7 +62,7 @@ typedef struct VncJobQueue VncJobQueue; > > /* > * We use a single global queue, but most of the functions are > - * already reetrant, so we can easilly add more than one encoding thread > + * already reentrant, so we can easily add more than one encoding thread > */ > static VncJobQueue *queue; Reviewed-by: Stefan Weil Cheers Stefan