Re: [Qemu-devel] [PATCH v3 08/16] block: introduce BLOCK_JOB_READY event

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1386 bytes --]

On 10/18/2012 08:49 AM, Paolo Bonzini wrote:
> Even for jobs that need to be manually completed, management may want
> to take care itself of the completion, not requiring the user to issue
> a command to terminate the job.  In this case we want to avoid that
> they poll us continuously, waiting for completion to become available.
> Thus, add a new event that signals the phase switch and the availability
> of the block-job-complete command.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

> +BLOCK_JOB_READY
> +---------------
> +
> +Emitted when a block job is ready to complete.
> +
> +Data:
> +
> +- "device": device name (json-string)
> +
> +Example:
> +
> +{ "event": "BLOCK_JOB_READY",
> +    "data": { "device": "ide0-hd1",
> +              "operation": "write",
> +              "action": "stop" },

This example does not match the Data above ('operation' and 'action'
were not documented.

> +    "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }

Just a reminder that libvirt would still like a followup patch later in
your series but prior to qemu 1.3 that adds a 'type':'str' (or even an
enum, with 'stream', 'commit', and 'mirror').  But we already agreed it
need not hold up this particular patch.

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]