From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Lovenberg Subject: Re: [PATCH] Add warning that NFS syntax is deprecated and will be removed in cifs-utils-6.0. Date: Thu, 18 Oct 2012 13:57:09 -0400 Message-ID: <508042F5.1030203@gmail.com> References: <1350582614-11930-1-git-send-email-scott.lovenberg@gmail.com> <1350582614-11930-2-git-send-email-scott.lovenberg@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, samba-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org, samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org To: scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Return-path: In-Reply-To: <1350582614-11930-2-git-send-email-scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On 10/18/2012 1:50 PM, scott.lovenberg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: > From: Scott Lovenberg > > Signed-off-by: Scott Lovenberg > --- > mount.cifs.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/mount.cifs.c b/mount.cifs.c > index 756fce2..061ce32 100644 > --- a/mount.cifs.c > +++ b/mount.cifs.c > @@ -1335,6 +1335,7 @@ static int parse_unc(const char *unc_name, struct parsed_mount_info *parsed_info > } > > /* Set up "host" and "share" pointers based on UNC format. */ > + /* TODO: Remove support for NFS syntax as of cifs-utils-6.0. */ > if (strncmp(unc_name, "//", 2)&& strncmp(unc_name, "\\\\", 2)) { > /* > * check for nfs syntax (server:/share/prepath) > @@ -1351,6 +1352,9 @@ static int parse_unc(const char *unc_name, struct parsed_mount_info *parsed_info > share++; > if (*share == '/') > ++share; > + fprintf(stderr, "WARNING: using NFS syntax for mounting CIFS " > + "shares is deprecated and will be removed in cifs-utils" > + "-6.0. Please migrate to UNC syntax."); > } else { > host = unc_name + 2; > hostlen = strcspn(host, "/\\"); Sorry, git send-email just blew up in my face. It was supposed to send a first email that explained the patch. Of course it worked perfectly when I tested it to my own email address. I'll figure out why the first message is missing and repost. Sorry for the noise.