From: Gary Thomas <gary@mlbassoc.com>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] [meta-oe] libav: Fix git URI
Date: Thu, 18 Oct 2012 12:29:00 -0600 [thread overview]
Message-ID: <50804A6C.5020607@mlbassoc.com> (raw)
In-Reply-To: <20121018174642.GC3087@jama.jama.net>
On 2012-10-18 11:46, Martin Jansa wrote:
> On Thu, Oct 18, 2012 at 10:51:29AM -0600, Gary Thomas wrote:
>> Specifying SRCREV and branch in the git SRC_URI confuses the bitbake
>> fetcher. This ends up with a saved tarball which contains neither
>> the SRCREV nor the branch, which in turn means the git tree needs
>> to be fetched every time even though a saved tarball has been created.
>
> That's fetcher fault.
>
> Branch is part of persistent db key for LOCALCOUNT, so this breaks
> upgrade path.
>
> Also AUTOREV wont work without branch specified in SRC_URI.
AUTOREV is not being used, so how does your comment apply?
>
> Fix bitbake fetcher instead.
>
> Cheers,
>
>
>> Simply removing the branch (which is redundant anyway) from the SRC_URI
>> makes everything happy.
>>
>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>> ---
>> meta-oe/recipes-multimedia/libav/libav_0.8.3.bb | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta-oe/recipes-multimedia/libav/libav_0.8.3.bb b/meta-oe/recipes-multimedia/libav/libav_0.8.3.bb
>> index 66a32c9..f9a2e06 100644
>> --- a/meta-oe/recipes-multimedia/libav/libav_0.8.3.bb
>> +++ b/meta-oe/recipes-multimedia/libav/libav_0.8.3.bb
>> @@ -6,13 +6,13 @@ LIC_FILES_CHKSUM = "file://COPYING.GPLv2;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
>> file://COPYING.LGPLv3;md5=e6a600fd5e1d9cbde2d983680233ad02"
>>
>> PV = "0.8.3+git${SRCPV}"
>> -PR = "${INC_PR}.0"
>> +PR = "${INC_PR}.1"
>>
>> # When bumping SRCREV make sure you bump PR here and in dependant
>> # recipes (gst-ffmpeg, gnash, omxil, etc) to account for SOVERSION
>> # changes
>> SRCREV = "2fb4be9a99a2c2a9435339830e3d940171cc0d9b"
>> -SRC_URI = "git://git.libav.org/libav.git;protocol=git;branch=release/0.8"
>> +SRC_URI = "git://git.libav.org/libav.git;protocol=git"
>>
>> S = "${WORKDIR}/git"
>>
>> --
>> 1.7.9.5
>>
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
next prev parent reply other threads:[~2012-10-18 18:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 16:51 [PATCH] [meta-oe] libav: Fix git URI Gary Thomas
2012-10-18 17:46 ` Martin Jansa
2012-10-18 18:29 ` Gary Thomas [this message]
2012-10-18 18:48 ` Martin Jansa
2012-10-18 20:05 ` Gary Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50804A6C.5020607@mlbassoc.com \
--to=gary@mlbassoc.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.