From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support.
Date: Thu, 18 Oct 2012 20:44:49 +0200 [thread overview]
Message-ID: <50804E21.6080401@redhat.com> (raw)
In-Reply-To: <507FD407.5020506@redhat.com>
Il 18/10/2012 12:03, Gerd Hoffmann ha scritto:
> Trying another approach, see attached patch. This adds backend-specific
> qemu commands to add chardevs, with just the parameters needed for the
> specific backend. Starting with file and tty, both accepting a path.
> 'file' is nice for testing, 'tty' very useful when hotplugging serial
> devices on the host. Others can be added as needed. We probably don't
> need all of them. For example hotplugging the 'stdio' chardev doesn't
> make much sense.
>
> Advantage #1: Cleaner API.
> Advantage #2: No legacy syntax headache when qomifying chardevs.
Disadvantage #1: Harder to extend, more code
Disadvantage #2: Different from all other kinds of host devices.
I still prefer the other one.
Paolo
next prev parent reply other threads:[~2012-10-18 18:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-17 10:09 [Qemu-devel] [PATCH 0/3] chardev hotplug patch series Gerd Hoffmann
2012-10-17 10:09 ` [Qemu-devel] [PATCH 1/3] chardev: add error reporting for qemu_chr_new_from_opts Gerd Hoffmann
2012-10-17 16:22 ` Luiz Capitulino
2012-10-17 10:09 ` [Qemu-devel] [PATCH 2/3] chardev: fix QemuOpts lifecycle Gerd Hoffmann
2012-10-17 16:40 ` Luiz Capitulino
2012-10-18 9:26 ` Gerd Hoffmann
2012-10-18 13:30 ` Luiz Capitulino
2012-10-17 10:09 ` [Qemu-devel] [PATCH 3/3] chardev: add hotplug support Gerd Hoffmann
2012-10-17 15:26 ` Eric Blake
2012-10-17 16:28 ` Paolo Bonzini
2012-10-18 10:03 ` Gerd Hoffmann
2012-10-18 18:44 ` Paolo Bonzini [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-12-14 9:38 [Qemu-devel] [PATCH RESENT 0/3] chardev hotplug patch series Gerd Hoffmann
2012-12-14 9:38 ` [Qemu-devel] [PATCH 3/3] chardev: add hotplug support Gerd Hoffmann
2012-12-14 12:17 ` Paolo Bonzini
2012-12-14 13:05 ` Eric Blake
2012-12-14 13:18 ` Gerd Hoffmann
2012-12-14 13:45 ` Paolo Bonzini
2012-12-14 14:05 ` Gerd Hoffmann
2012-12-14 14:19 ` Gerd Hoffmann
2012-12-14 15:07 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50804E21.6080401@redhat.com \
--to=pbonzini@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.