All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Phil Blundell <philb@gnu.org>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] strace: Don't package strace-graph
Date: Thu, 18 Oct 2012 13:03:20 -0700	[thread overview]
Message-ID: <50806088.6080805@linux.intel.com> (raw)
In-Reply-To: <1348654710.31293.93.camel@phil-desktop>

On 09/26/2012 03:18 AM, Phil Blundell wrote:
> Commit 9c9ea24b115a9bb87df1323b5f185ce426262aec made strace depend on perl because the
> strace-graph script needs it.  However, this cost of the dependency is large (building
> all of perl) and the value of the script is marginal.  Let's just delete the script
> instead and remove the dependency again.
>
> If anybody wants strace-graph then it should be packaged in its own recipe and that one
> can be made to depend on perl without disrupting the main strace package.
>
> Signed-off-by: Phil Blundell <pb@pbcl.net>
> ---
>   meta/recipes-devtools/strace/strace_4.7.bb |   11 ++++++-----
>   1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/meta/recipes-devtools/strace/strace_4.7.bb b/meta/recipes-devtools/strace/strace_4.7.bb
> index 21dd47a..e1a5e82 100644
> --- a/meta/recipes-devtools/strace/strace_4.7.bb
> +++ b/meta/recipes-devtools/strace/strace_4.7.bb
> @@ -3,11 +3,7 @@ HOMEPAGE = "http://strace.sourceforge.net"
>   SECTION = "console/utils"
>   LICENSE = "BSD"
>   LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=124500c21e856f0912df29295ba104c7"
> -PR = "r1"
> -
> -PACKAGES =+ "${PN}-graph "
> -FILES_${PN}-graph = "${bindir}/strace-graph"
> -RDEPENDS_${PN}-graph = "perl"
> +PR = "r2"
>
>   SRC_URI = "${SOURCEFORGE_MIRROR}/strace/strace-${PV}.tar.xz \
>              file://strace-eglibc-2.16.patch \
> @@ -20,4 +16,9 @@ inherit autotools
>
>   export INCLUDES = "-I. -I./linux"
>
> +do_install_append() {
> +	# We don't ship strace-graph here because it needs perl
> +	rm ${D}${bindir}/strace-graph
> +}
> +
>   BBCLASSEXTEND = "native"
>
Merged into OE-Core

Thanks
	Sau!




      reply	other threads:[~2012-10-18 20:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-26 10:18 [PATCH] strace: Don't package strace-graph Phil Blundell
2012-10-18 20:03 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50806088.6080805@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=philb@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.