From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com ([134.134.136.20]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1TOwod-00067C-EV for openembedded-core@lists.openembedded.org; Thu, 18 Oct 2012 22:35:39 +0200 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 18 Oct 2012 13:22:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,609,1344236400"; d="scan'208";a="207817006" Received: from unknown (HELO envy.home) ([10.255.14.53]) by orsmga001.jf.intel.com with ESMTP; 18 Oct 2012 13:22:15 -0700 Message-ID: <508064BB.8070802@linux.intel.com> Date: Thu, 18 Oct 2012 16:21:15 -0400 From: Darren Hart User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121009 Thunderbird/16.0 MIME-Version: 1.0 To: McClintock Matthew-B29882 References: <1350554279-8975-1-git-send-email-yashpal.dutta@freescale.com> <7A2134DD-519C-4FFB-ACEE-8E36E7A5A088@gmail.com> <50805F8F.5050604@linux.intel.com> <70CC66F5C30A414DADDA6973E4CA391A7092EF@039-SN1MPN1-002.039d.mgd.msft.net> In-Reply-To: <70CC66F5C30A414DADDA6973E4CA391A7092EF@039-SN1MPN1-002.039d.mgd.msft.net> X-Enigmail-Version: 1.4.5 Cc: "openembedded-core@lists.openembedded.org" Subject: Re: [PATCH] cryptodev kernel module recipe X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Oct 2012 20:35:39 -0000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 10/18/2012 04:06 PM, McClintock Matthew-B29882 wrote: > On Thu, Oct 18, 2012 at 2:59 PM, Darren Hart wrote: >> >> >> On 10/18/2012 02:14 AM, Khem Raj wrote: >>> >>> On Oct 18, 2012, at 2:57 AM, Yashpal Dutta wrote: >>> >>>> +-install: >>>> ++modules_install: >>>> + make -C $(KERNEL_DIR) SUBDIRS=`pwd` modules_install >>>> +- @echo "Installing cryptodev.h in /usr/include/crypto ..." >>>> +- @install -D crypto/cryptodev.h /usr/include/crypto/cryptodev.h >>>> ++ @echo "Installing cryptodev.h in $(PREFIX)/usr/include/crypto ..." >>>> ++ @install -D crypto/cryptodev.h $(PREFIX)/usr/include/crypto/cryptodev.h >>>> + >>> >>> why is it installing linux headers under /usr/include shouldn't they be under usr/include/linux ? >> >> And shouldn't /usr/include be one of those ${*dir} variables? > > That's a patch to a Makefile... not a recipe. Duh.... hrm. I'm not sure how we deal with this typically. -- Darren Hart Intel Open Source Technology Center Yocto Project - Technical Lead - Linux Kernel